Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profile] Support show load profile for broker load job #6214

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Jul 13, 2021

Proposed changes

Add new statement:
SHOW LOAD PROFILE "xxx";

show load profile "/"; # list all saving load job ids
show load profile "/10014" # show task ids of specified job
show load profile "/10014/e0f7390f5363419e-b416a2a79996083e/" # show instance list of the task
show load profile "/10014/e0f7390f5363419e-b416a2a79996083e/e0f7390f5363419e-b416a2a799960906" # show instance tree graph

Improve the read performance of orc scanner

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added kind/feature Categorizes issue or PR as related to a new feature. area/load Issues or PRs related to all kinds of load area/profile Issues or PRs related to the profile labels Jul 13, 2021
@morningman morningman force-pushed the show_load_profile branch 2 times, most recently from fb1cfdb to 5b2d5db Compare July 13, 2021 02:33
EmmyMiao87
EmmyMiao87 previously approved these changes Jul 14, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Jul 14, 2021
@morningman morningman force-pushed the show_load_profile branch 3 times, most recently from 812e287 to 4f907d7 Compare July 19, 2021 01:42
morningman-cmy and others added 2 commits July 20, 2021 12:22
1.
Add new statement:
`SHOW LOAD PROFILE "xxx";`

2.
Improve the read perfermance of orc scanner
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit f26e340 into apache:master Jul 27, 2021
@morningman morningman mentioned this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load area/profile Issues or PRs related to the profile kind/feature Categorizes issue or PR as related to a new feature. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants