[Backport] Uniformly set Calcite systemProperties for All Unit tests #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes test failures reported in - apache#4909 Issue is that If some test skips setting up Calcite system properties with proper encoding and loads calcite classes that use that property, All subsequent tests in the same JVM fails. To reproduce the issue - ExpressionsTest and CalciteQueryTest from IDE in this order. A better fix would be to not use System Properties in calcite, This will work for now. All new Calcite Unit tests that are added need to inherit CalciteTestBase.
|
You might want to backport #5959 too. This patch's tests failed because of that one. I restarted them both so let's hope for the best. |
|
This one managed to pass CI after a couple restarts so I'll merge it. Please merge master into #5975 when you can. |
|
Merged #5975. Thanks. |
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 20, 2018
… (apache#5977) Fixes test failures reported in - apache#4909 Issue is that If some test skips setting up Calcite system properties with proper encoding and loads calcite classes that use that property, All subsequent tests in the same JVM fails. To reproduce the issue - ExpressionsTest and CalciteQueryTest from IDE in this order. A better fix would be to not use System Properties in calcite, This will work for now. All new Calcite Unit tests that are added need to inherit CalciteTestBase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5451 to 0.12.2.
Looks like many travis jobs are failing because of lack of this patch.