Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let cachingCost balancer strategy only consider segment replicatable nodes #6879

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Let cachingCost balancer strategy only consider segment replicatable nodes #6879

merged 1 commit into from
Jan 17, 2019

Conversation

QiuMM
Copy link
Member

@QiuMM QiuMM commented Jan 17, 2019

There is no need to waste memory resources and cpu time on REALTIME and INDEXER_EXECUTOR nodes.

clintropolis
clintropolis approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, 👍 after CI

asdf2014
asdf2014 approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drcrallen
Copy link
Contributor

Yes please!

@gianm gianm merged commit b704ebf into apache:master Jan 17, 2019
@QiuMM QiuMM added this to the 0.14.0 milestone Feb 12, 2019
@jon-wei jon-wei mentioned this pull request Feb 22, 2019
Closed
@love1693294577
Copy link

There is no need to waste memory resources and cpu time on REALTIME and INDEXER_EXECUTOR nodes.

---------- Previously the strategy would unnecessarily consider active worker tasks as well------;

What does this mean, I don't quite understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis approved these changes

@asdf2014 asdf2014 asdf2014 approved these changes

@drcrallen drcrallen drcrallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@QiuMM @drcrallen @love1693294577 @clintropolis @asdf2014 @gianm