Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time taken by last query in SQL view #7421

Merged
merged 4 commits into from Apr 11, 2019
Merged

Add time taken by last query in SQL view #7421

merged 4 commits into from Apr 11, 2019

Conversation

shuqi7
Copy link
Contributor

@shuqi7 shuqi7 commented Apr 5, 2019

  • Showing time taken by last query in SQL view
    image

vogievetsky
vogievetsky reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review some feedback

web-console/src/views/sql-view.tsx Outdated Show resolved Hide resolved
web-console/src/components/sql-control.tsx Outdated Show resolved Hide resolved
web-console/src/views/sql-view.tsx Outdated Show resolved Hide resolved
@vogievetsky
Copy link
Contributor

Looks good, thank you for addressing the feedback changes 👍

clintropolis
clintropolis approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, 👍

@clintropolis clintropolis added this to the 0.15.0 milestone Apr 11, 2019
@clintropolis clintropolis merged commit 4ea37e2 into apache:master Apr 11, 2019
@clintropolis clintropolis deleted the console-query-time branch April 11, 2019 06:35
clintropolis pushed a commit to implydata/druid-public that referenced this pull request Apr 11, 2019
@shuqi7 @clintropolis
Add time taken by last query in SQL view (apache#7421)
aba2de6 
* Add time taken by query

* Fix time to 2 dp; set state in on state change; hide time taken at first

* Refactored code: defined query result interface; more concise shorthand expression

* Use single quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogievetsky vogievetsky vogievetsky left review comments

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Web Console
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuqi7 @vogievetsky @clintropolis