Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add s3 authentication method informations #7674

Merged
merged 5 commits into from
May 22, 2019

Conversation

giom-l
Copy link
Contributor

@giom-l giom-l commented May 16, 2019

Add informations about how Druid handle s3 authentication and what is the precedence between methods

|order|type|details|
|--------|-----------|-------|
|1|Druid config file|Based on your runtime.properties if it contains values `druid.s3.accessKey` and `druid.s3.secretKey` |
|2|Custom properties file| Based on custom properties file where you can supply `sessionToken`, `accessKey` and `secretKey` values|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if you document 'druid.s3.fileSessionCredentials' as well or else this point is harder to understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are perfectly right, I forgot it.
i added the property and some precisions about how to set those properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering is that could not be better to remove informations in /content/configuration/index.md about s3 deep storage and just let the link to s3.md page.
That would avoid information duplication, no?
If OK, I'll just report druid.storage.useS3aSchema in s3.md and make the link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, for the auth stuff , there are other deep storage specific properties which should still be left there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I also reported properties that were on one side but not on other (when relevant).

@himanshug
Copy link
Contributor

LGTM after the build.

@giom-l
Copy link
Contributor Author

giom-l commented May 22, 2019

Should i do something about the build not passing ? Seems like a timeout during tests

@gianm
Copy link
Contributor

gianm commented May 22, 2019

I restarted that one, it might have flaked out.

@giom-l
Copy link
Contributor Author

giom-l commented May 22, 2019

Thanks, it worked !

@himanshug himanshug merged commit bd899b9 into apache:master May 22, 2019
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants