-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add s3 authentication method informations #7674
Conversation
|order|type|details| | ||
|--------|-----------|-------| | ||
|1|Druid config file|Based on your runtime.properties if it contains values `druid.s3.accessKey` and `druid.s3.secretKey` | | ||
|2|Custom properties file| Based on custom properties file where you can supply `sessionToken`, `accessKey` and `secretKey` values| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if you document 'druid.s3.fileSessionCredentials' as well or else this point is harder to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are perfectly right, I forgot it.
i added the property and some precisions about how to set those properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering is that could not be better to remove informations in /content/configuration/index.md about s3 deep storage and just let the link to s3.md page.
That would avoid information duplication, no?
If OK, I'll just report druid.storage.useS3aSchema
in s3.md and make the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, for the auth stuff , there are other deep storage specific properties which should still be left there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. I also reported properties that were on one side but not on other (when relevant).
LGTM after the build. |
Should i do something about the build not passing ? Seems like a timeout during tests |
I restarted that one, it might have flaked out. |
Thanks, it worked ! |
Add informations about how Druid handle s3 authentication and what is the precedence between methods