Fix broken master #9005
Merged
Fix broken master #9005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /** See the description of this endpoint in api-reference.md. */ | ||
| @GET | ||
| @Path("/status/selfDiscoveredStatus") | ||
| @Path("/status") |
There was a problem hiding this comment.
Since this changes the API path of /status/selfDiscoveredStatus to /status/selfDiscovered/status the docs in api-reference.md need updated
There was a problem hiding this comment.
Oops, thanks. Fixed.
9 tasks
clintropolis
approved these changes
Dec 11, 2019
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Dec 13, 2019
* Multibinding for NodeRole * Fix endpoints * fix doc * fix test
jon-wei
pushed a commit
that referenced
this pull request
Dec 13, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9002.
Description
This PR uses multibinding to fix the binding bug in overlord + coordinator mode. Also fixes the bug in
SelfDiscoveryResourcethat APIs are not bound properly.This PR has:
This change is