Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade libthrift version and add nature thrift support option #1380

Closed
wants to merge 19 commits into from
Closed

upgrade libthrift version and add nature thrift support option #1380

wants to merge 19 commits into from

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Feb 21, 2018

What is the purpose of the change

1.upgrade libthrift to version0.11.0
2.add nature thrift support option
3.upgrade fastjson to version 1.2.46

Brief changelog

Code in module dubbo/dubbo-rpc/dubbo-rpc-thrift is modified

Verifying this change

1.Config in dubbo/dubbo-rpc/dubbo-rpc-thrift/src/test/resources/dubbo-demo-consumer.xml

<?xml version="1.0" encoding="UTF-8"?>

<beans xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xmlns:dubbo="http://code.alibabatech.com/schema/dubbo"
       xmlns="http://www.springframework.org/schema/beans"
       xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
    http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd">

    <dubbo:application name="dubbo-demo-consumer"/>

    <dubbo:registry address="zookeeper://127.0.0.1:2181"/>

    <dubbo:protocol name="thrift"/>

    <dubbo:reference id="demoService" nativethrift="true" interface="com.alibaba.dubbo.rpc.gen.thrift.Demo$Iface" timeout="1000000"/>

</beans>

add nativethrift="true" property

2.Run main method of dubbo/dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/examples/DubboThriftDemoConsumer.java tp startup the provider service

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #1380 into master will decrease coverage by <.01%.
The diff coverage is 5.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1380      +/-   ##
============================================
- Coverage     39.24%   39.24%   -0.01%     
- Complexity     4197     4198       +1     
============================================
  Files           618      618              
  Lines         29742    29760      +18     
  Branches       5257     5263       +6     
============================================
+ Hits          11672    11678       +6     
- Misses        16211    16223      +12     
  Partials       1859     1859
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/schema/DubboBeanDefinitionParser.java 20.81% <0%> (-0.26%) 18 <0> (ø)
...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java 2.95% <2.22%> (-0.1%) 5 <0> (ø)
...n/java/com/alibaba/dubbo/config/ServiceConfig.java 39.9% <50%> (+0.09%) 44 <1> (+1) ⬆️
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 74.76% <0%> (-1.87%) 7% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 50% <0%> (+12.5%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2030789...996c292. Read the comment docs.

@chickenlj
Copy link
Contributor

Excellent, i will have a review on it.

@ralf0131
Copy link
Contributor

  1. Please fix the CI failure
  2. Please resolve the conflicts.

@diecui1202
Copy link

diecui1202 commented Jun 4, 2018

I think we could implement a protocol extension named "native-thrift", and place it under http://github.com/dubbo

Yeah, here it is. https://github.com/dubbo/dubbo-rpc-native-thrift

@lovepoem lovepoem closed this Jun 4, 2018
@wuhuajie
Copy link

wuhuajie commented Jan 21, 2019

Wonder to know which dubbo version this issue is included in?

@lovepoem
Copy link
Member Author

Now the thrift issues can be in the new project : https://github.com/dubbo/dubbo-rpc-native-thrift @wuhuajie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants