-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade libthrift version and add nature thrift support option #1380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
============================================
- Coverage 39.24% 39.24% -0.01%
- Complexity 4197 4198 +1
============================================
Files 618 618
Lines 29742 29760 +18
Branches 5257 5263 +6
============================================
+ Hits 11672 11678 +6
- Misses 16211 16223 +12
Partials 1859 1859
Continue to review full report at Codecov.
|
Excellent, i will have a review on it. |
|
I think we could implement a protocol extension named "native-thrift", and place it under http://github.com/dubbo Yeah, here it is. https://github.com/dubbo/dubbo-rpc-native-thrift |
Wonder to know which dubbo version this issue is included in? |
Now the thrift issues can be in the new project : https://github.com/dubbo/dubbo-rpc-native-thrift @wuhuajie |
What is the purpose of the change
1.upgrade
libthrift
to version0.11.0
2.add nature thrift support option
3.upgrade
fastjson
to version1.2.46
Brief changelog
Code in module dubbo/dubbo-rpc/dubbo-rpc-thrift is modified
Verifying this change
1.Config in
dubbo/dubbo-rpc/dubbo-rpc-thrift/src/test/resources/dubbo-demo-consumer.xml
add
nativethrift="true"
property2.Run main method of
dubbo/dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/examples/DubboThriftDemoConsumer.java tp startup the provider service