Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hyphen instead of camel for prefix #3119

Merged
merged 1 commit into from
Jan 3, 2019
Merged

use hyphen instead of camel for prefix #3119

merged 1 commit into from
Jan 3, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jan 3, 2019

What is the purpose of the change

we should use hyphen case instead of camel case in dubbo.properties, for example:

dubbo.config-center.Foo instead of dubbo.configCenter.Foo

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3119 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3119      +/-   ##
============================================
- Coverage     63.67%   63.52%   -0.15%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28190    28190              
  Branches       4784     4784              
============================================
- Hits          17950    17908      -42     
- Misses         7989     8026      +37     
- Partials       2251     2256       +5
Impacted Files Coverage Δ Complexity Δ
...g/context/annotation/DubboConfigConfiguration.java 66.66% <ø> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 73.52% <0%> (-11.77%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) 0% <0%> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 78.12% <0%> (-6.25%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ebfe8...dfa7030. Read the comment docs.

@khanimteyaz
Copy link
Contributor

Looks fine to me.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 0d04cfd into apache:master Jan 3, 2019
@beiwei30 beiwei30 deleted the hyper-separator branch January 3, 2019 07:43
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants