Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar scatter with problems in some months #8047

Closed
luissmg opened this issue Mar 28, 2018 · 3 comments
Closed

Calendar scatter with problems in some months #8047

luissmg opened this issue Mar 28, 2018 · 3 comments
Labels
stale Inactive for a long time. Will be closed in 7 days.

Comments

@luissmg
Copy link

luissmg commented Mar 28, 2018

One-line summary

When using series type as scatter and coordinateSystem as calendar some months have the days out of position and the month as his line out of place too. In this cases the calendar and day labels also change positions for some weird reason.

Version & Environment

  • ECharts version: 4.0.4
  • Browser version: Firefox Quantum 59.0.2
  • OS Version: Windows 10

Expected behaviour:

I would expect the same behaviour as in the other months. Check the screenshots and ECharts option section in this issue!

ECharts option

Access to this page and in the function getVirtulData change the following variables:

var date = +echarts.number.parseDate('2018-10-01');
var end = +echarts.number.parseDate('2018-11-01');

Also change the range property in option object to '2018-10'.

Other comments

All the screenshots have been taken width the same window size and position to make comparison easier!

Working month (2018-09): (calendar in the middle)
imagem

Non-working month (2018-10): (calendar in the bottom for some reason)
imagem

@MickaelNeves
Copy link

+1

@luissmg
Copy link
Author

luissmg commented Apr 4, 2018

So, I was exploring the library and got news.
The problem with the positioning of the day (31) going on top is with (I think) the line 356 in Calendar.js. I tried some stuff and it actually solved the problem, but only for this month. My solution was then adding bugs in other months.
Besides that, my solution was only fixing the position of the day. The lines were still wrong, so I think there is a problem with the function _renderLines (or any other callend inside) in CalendarView.js.

Can someone look into this?

@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive for a long time. Will be closed in 7 days. label Apr 3, 2020
@stale stale bot closed this as completed Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive for a long time. Will be closed in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants