Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] [BREAK] move map data to test folder. not included in the npm package. #13565

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Nov 8, 2020

This pull request will move the map data to the test folder. So it won't be included in the npm package and jsdelivr CDN

@echarts-bot
Copy link

echarts-bot bot commented Nov 8, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit e0de745 into release Nov 8, 2020
@echarts-bot
Copy link

echarts-bot bot commented Nov 8, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the remove-map branch November 8, 2020 07:57
@euxx
Copy link

euxx commented Dec 10, 2020

@pissang Hi, Would you please tell me how do I suppose to do to keep using this map with ECharts 5.0? Any suggestion? Thanks.

@lfjdhr123
Copy link

@pissang Hi, Would you please tell me how do I suppose to do to keep using this map with ECharts 5.0? Any suggestion? Thanks.

copy the geoJSON file from the earlier version (4.9.0) , import it by yourself. It works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants