Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Cannot find the webhook protocol adaptor #1367

Closed
1 of 2 tasks
Alonexc opened this issue Sep 23, 2022 · 2 comments · Fixed by #1370
Closed
1 of 2 tasks

[Bug] Cannot find the webhook protocol adaptor #1367

Alonexc opened this issue Sep 23, 2022 · 2 comments · Fixed by #1370
Assignees
@cocodroid
Labels
bug Something isn't working
Milestone
1.7.0

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Sep 23, 2022 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

image

This bug occurred while doing an eventmesh webhook test.

How to reproduce

  1. Register the webhook interface with eventmesh according to the webhook document.
  2. Start an http server interface and register it with eventmesh for listening.
  3. Bind the webhook interface to the GitHub repository.
  4. Trigger a GitHub event.

Debug logs

Bug cause:
image
image

Located at:org/apache/eventmesh/protocol/webhook/WebHookProtocolAdaptor line 49

The protocol type key does not correspond to it.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the bug Something isn't working label Sep 23, 2022
@Alonexc Alonexc changed the title [Bug] The webhooh protocol api is not mapped [Bug] Cannot find the webhook protocol adaptor Sep 23, 2022
@cocodroid
Copy link
Contributor

please assign to me

@qqeasonchen
Copy link
Contributor

sure @cocodroid

@cocodroid cocodroid mentioned this issue Sep 23, 2022
Merged
@xwm1992 xwm1992 added this to the 1.7.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cocodroid cocodroid

Labels
bug Something isn't working
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #1367] fixed webHook protocol adaptor cocodroid/incubator-eventmesh
4 participants
@cocodroid @xwm1992 @qqeasonchen @Alonexc