[ISSUE #900] Support Consul Service Registry #901

huyuanxin · 2022-05-31T08:38:11Z

Fixes ISSUE #900

Motivation

make an implement of RegistryService which is support by consul

Modifications

Describe the modifications you've done.

Add ConsulRegistryService and ConsulConstant for implement
Add ConsulRegistryServiceTest for test

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

github-actions

Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Group：

Mailing Lists:

Name	Description	Subscribe	Unsubscribe	Archive
Users	User support and questions mailing list	Subscribe	Unsubscribe	Mail Archives
Development	Development related discussions	Subscribe	Unsubscribe	Mail Archives
Commits	All commits to repositories	Subscribe	Unsubscribe	Mail Archives

codecov · 2022-05-31T09:21:20Z

Codecov Report

Merging #901 (6e70ffb) into master (6e70ffb) will not change coverage.
The diff coverage is n/a.

❗ Current head 6e70ffb differs from pull request most recent head 9340d67. Consider uploading reports for the commit 9340d67 to get more accurate results

@@           Coverage Diff            @@
##             master    #901   +/-   ##
========================================
  Coverage      9.72%   9.72%           
  Complexity      614     614           
========================================
  Files           362     362           
  Lines         23126   23126           
  Branches       2548    2548           
========================================
  Hits           2249    2249           
  Misses        20673   20673           
  Partials        204     204

huyuanxin · 2022-05-31T10:10:42Z

It seems that MacOS 11 build scrip is failed, because could not get resource

qqeasonchen

seems miss lisence declare

huyuanxin · 2022-06-01T00:20:13Z

seems miss lisence declare

FAILURE: Build failed with an exception.
38 actionable tasks: 5 executed, 33 up-to-date

What went wrong:
Execution failed for task ':eventmesh-common:compileJava'.

Could not resolve all files for configuration ':eventmesh-common:compileClasspath'.
Could not download log4j-core-2.17.1.jar (org.apache.logging.log4j:log4j-core:2.17.1)
> Could not get resource 'https://maven.aliyun.com/repository/public/org/apache/logging/log4j/log4j-core/2.17.1/log4j-core-2.17.1.jar'.
> Premature end of Content-Length delimited message body (expected: 1,790,452; received: 70,916)

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org/

BUILD FAILED in 2m 10s

it seems there is something wrong with gradle build

qqeasonchen · 2022-06-01T02:20:56Z

@xiaoyang-sde please help to review

xiaoyang-sde · 2022-06-01T02:47:41Z

@xiaoyang-sde please help to review

Sure! I will review it later today.

xiaoyang-sde

Thanks for the contribution! It seems that the changes failed to pass the style check: https://github.com/apache/incubator-eventmesh/runs/6681779883?check_suite_focus=true#step:5:9859. Could you please try to fix this?

huyuanxin · 2022-06-02T01:44:19Z

yep. I will fix it later or tomorrow, work is busy

qqeasonchen · 2022-06-10T08:23:54Z

@huyuanxin any udpates?

qqeasonchen · 2022-06-10T08:25:11Z

@li-xiao-shuang please help to review.

huyuanxin · 2022-06-10T09:09:00Z

already done, but some check still can't be resolved. I can't figure it out 在 2022年6月10日，16:24，Eason Chen ***@***.***> 写道： @huyuanxin<https://github.com/huyuanxin> any udpates? — Reply to this email directly, view it on GitHub<#901 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKC764POFM5KLP3ZKE3DAM3VOL3SNANCNFSM5XMX3GHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

huyuanxin · 2022-06-10T09:10:05Z

Already done. But I can't figure out how to fix the action checks 在 2022年6月10日，16:24，Eason Chen ***@***.***> 写道： @huyuanxin<https://github.com/huyuanxin> any udpates? — Reply to this email directly, view it on GitHub<#901 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKC764POFM5KLP3ZKE3DAM3VOL3SNANCNFSM5XMX3GHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

li-xiao-shuang · 2022-06-12T06:46:03Z

@li-xiao-shuang please help to review.

Yes, I'm working on it

li-xiao-shuang · 2022-06-12T08:26:49Z

You should create a META-INF/eventmesh/org.apache.eventmesh.api.registry.RegistryService file for the consul plugin so the eventmesh spi will find it

...consul/src/main/java/org/apache/eventmesh/registry/consul/service/ConsulRegistryService.java

li-xiao-shuang · 2022-06-12T09:26:45Z

How does the heartbeat of the consul service work? Need manual maintenance?

qqeasonchen · 2022-06-13T11:28:12Z

@huyuanxin, please fix the issues that reqeust by @li-xiao-shuang

huyuanxin · 2022-06-13T11:32:41Z

ok， I will fix it later---- Replied Message ----FromEason ***@***.***>Date06/13/2022 19:28 ***@***.***> CcYuanXin ***@***.******@***.***>SubjectRe: [apache/incubator-eventmesh] Support Consul Service Registry (PR #901) @huyuanxin, please fix the issues that reqeust by @li-xiao-shuang —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#901 (comment)", "url": "#901 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

xwm1992 · 2022-06-30T10:02:43Z

please solve the conflic files @huyuanxin .

qqeasonchen · 2022-07-19T01:49:43Z

@huyuanxin can you please fix the conflicts？

huyuanxin · 2022-07-19T02:00:32Z

@huyuanxin can you please fix the conflicts？

fixing

huyuanxin · 2022-07-19T02:35:22Z

I cherry pick into the branch that is from the latest upstream

xwm1992 · 2022-07-28T06:27:18Z

I have created the registry-consul branch please merge this pr to this branch and we will fix the ci problems later. @huyuanxin

[ISSUE apache#900] Support Consul Service Registry

github-actions bot reviewed May 31, 2022

View reviewed changes

qqeasonchen reviewed May 31, 2022

View reviewed changes

qqeasonchen requested a review from xiaoyang-sde June 1, 2022 02:20

xiaoyang-sde assigned huyuanxin Jun 1, 2022

xiaoyang-sde added the enhancement New feature or request label Jun 1, 2022

xiaoyang-sde changed the title ~~add consul registry implement~~ Support Consul Service Registry Jun 1, 2022

xiaoyang-sde requested changes Jun 2, 2022

View reviewed changes

huyuanxin marked this pull request as draft June 6, 2022 02:31

qqeasonchen marked this pull request as ready for review June 10, 2022 08:22

li-xiao-shuang reviewed Jun 12, 2022

View reviewed changes

...consul/src/main/java/org/apache/eventmesh/registry/consul/service/ConsulRegistryService.java Outdated Show resolved Hide resolved

li-xiao-shuang reviewed Jun 12, 2022

View reviewed changes

...consul/src/main/java/org/apache/eventmesh/registry/consul/service/ConsulRegistryService.java Outdated Show resolved Hide resolved

li-xiao-shuang reviewed Jun 12, 2022

View reviewed changes

...consul/src/main/java/org/apache/eventmesh/registry/consul/service/ConsulRegistryService.java Outdated Show resolved Hide resolved

xwm1992 changed the title ~~Support Consul Service Registry~~ [ISSUE #900] Support Consul Service Registry Jul 7, 2022

huyuanxin added 14 commits July 19, 2022 10:23

add consul registry implement

c075a68

add consul registry implement

ffc6b8f

add consul licence

c2f90e7

add consul

ce1f9a3

style fix lint

9a80a77

style fix lint

6dc84c2

style fix lint

a6103d6

style fix lint

41b5c52

style fix lint

a1ca093

create spi file

3e1156b

remove unused file

c86b3be

resolve conversation

42bd6d1

add token support

3f91677

feat: add new impl

21218ad

huyuanxin added 2 commits July 19, 2022 10:45

feat: add licence header

d5dcc56

refactor: move to java

f7d7130

huyuanxin requested a review from xiaoyang-sde July 19, 2022 02:53

style: replace Chinese to English

9340d67

li-xiao-shuang approved these changes Jul 25, 2022

View reviewed changes

xwm1992 changed the base branch from master to registry-consul July 28, 2022 06:44

xiaoyang-sde removed their request for review July 28, 2022 06:52

xwm1992 merged commit 4ba8836 into apache:registry-consul Jul 28, 2022

xwm1992 added a commit to xwm1992/EventMesh that referenced this pull request Aug 6, 2022

Merge pull request apache#901 from huyuanxin/consul-regisrty

a1a574c

[ISSUE apache#900] Support Consul Service Registry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #900] Support Consul Service Registry #901

[ISSUE #900] Support Consul Service Registry #901

huyuanxin commented May 31, 2022

github-actions bot left a comment

codecov bot commented May 31, 2022 •

edited

huyuanxin commented May 31, 2022

qqeasonchen left a comment

huyuanxin commented Jun 1, 2022

qqeasonchen commented Jun 1, 2022

xiaoyang-sde commented Jun 1, 2022

xiaoyang-sde left a comment •

edited

huyuanxin commented Jun 2, 2022

qqeasonchen commented Jun 10, 2022

qqeasonchen commented Jun 10, 2022

huyuanxin commented Jun 10, 2022 via email

huyuanxin commented Jun 10, 2022 via email

li-xiao-shuang commented Jun 12, 2022

li-xiao-shuang commented Jun 12, 2022

li-xiao-shuang commented Jun 12, 2022

qqeasonchen commented Jun 13, 2022

huyuanxin commented Jun 13, 2022 via email

xwm1992 commented Jun 30, 2022

qqeasonchen commented Jul 19, 2022

huyuanxin commented Jul 19, 2022

huyuanxin commented Jul 19, 2022 •

edited

xwm1992 commented Jul 28, 2022

[ISSUE #900] Support Consul Service Registry #901

[ISSUE #900] Support Consul Service Registry #901

Conversation

huyuanxin commented May 31, 2022

Motivation

Modifications

Documentation

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented May 31, 2022 • edited

Codecov Report

huyuanxin commented May 31, 2022

qqeasonchen left a comment

Choose a reason for hiding this comment

huyuanxin commented Jun 1, 2022

qqeasonchen commented Jun 1, 2022

xiaoyang-sde commented Jun 1, 2022

xiaoyang-sde left a comment • edited

Choose a reason for hiding this comment

huyuanxin commented Jun 2, 2022

qqeasonchen commented Jun 10, 2022

qqeasonchen commented Jun 10, 2022

huyuanxin commented Jun 10, 2022 via email

huyuanxin commented Jun 10, 2022 via email

li-xiao-shuang commented Jun 12, 2022

li-xiao-shuang commented Jun 12, 2022

li-xiao-shuang commented Jun 12, 2022

qqeasonchen commented Jun 13, 2022

huyuanxin commented Jun 13, 2022 via email

xwm1992 commented Jun 30, 2022

qqeasonchen commented Jul 19, 2022

huyuanxin commented Jul 19, 2022

huyuanxin commented Jul 19, 2022 • edited

xwm1992 commented Jul 28, 2022

codecov bot commented May 31, 2022 •

edited

xiaoyang-sde left a comment •

edited

huyuanxin commented Jul 19, 2022 •

edited