Skip to content

Commit

Permalink
Merge branch 'main' into wip_ts
Browse files Browse the repository at this point in the history
  • Loading branch information
rui-mo committed Apr 24, 2023
2 parents 9b4f120 + b712b53 commit 6875a21
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions cpp/velox/compute/WholeStageResultIterator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ void WholeStageResultIterator::setConfToQueryContext(const std::shared_ptr<velox
}
// To align with Spark's behavior, set casting to int to be truncating.
configs[velox::core::QueryConfig::kCastIntByTruncate] = std::to_string(true);
// To align with Spark's behavior, allow decimal in casting string to int.
configs[velox::core::QueryConfig::kCastIntAllowDecimal] = std::to_string(true);

// Spill configs
configs[velox::core::QueryConfig::kSpillEnabled] = getConfigValue(kSpillEnabled, "true");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ case class FallbackEmptySchemaRelation() extends Rule[SparkPlan] {
// Some backends are not eligible to offload plan with zero-column input.
// If any child have empty output, mark the plan and that child as UNSUPPORTED.
logWarning(s"May fallback ${p.getClass.toString} and its children because" +
s"at least one of its children has empty output.")
s" at least one of its children has empty output.")
TransformHints.tagNotTransformable(p)
p.children.foreach(child =>
if (child.output.isEmpty) TransformHints.tagNotTransformable(child))
Expand Down

0 comments on commit 6875a21

Please sign in to comment.