Skip to content

Commit

Permalink
Fix compile issue
Browse files Browse the repository at this point in the history
  • Loading branch information
JkSelf committed May 15, 2024
1 parent 3a182ac commit 68e89b0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -619,13 +619,15 @@ bool SubstraitToVeloxPlanValidator::validate(const ::substrait::WindowRel& windo
bool resolved = false;
for (const auto& signature : signaturesOpt.value()) {
// The rank like functions don't need argument.
if (rankLikeNames.find(funcName) != rankLikeNames.end()) {
if (std::find(rankLikeNames.begin(), rankLikeNames.end(), funcName) != rankLikeNames.end()) {
types.clear();
}

// The lead and lag argument only need the first element.
if (leadLagNames.find(funcName) != leadLagNames.end()) {
if (std::find(leadLagNames.begin(), leadLagNames.end(), funcName) != leadLagNames.end()) {
types.resize(1);
}

exec::SignatureBinder binder(*signature, types);
if (binder.tryBind()) {
auto type = binder.tryResolveType(signature->returnType());
Expand Down

0 comments on commit 68e89b0

Please sign in to comment.