New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Use exists() instead of map().exists() to improve code readability #3979

Closed

dcoliversun opened this issue Dec 8, 2023 · 0 comments · Fixed by #3980

Labels

Contributor

dcoliversun commented Dec 8, 2023

Description

Current, gluten use Seq.map().exists() to determine whether the specified node exists in the plan, it is better to use Seq.exists() to simply code and improve readability
https://github.com/oap-project/gluten/blob/305924a19025f5ff0a65de0d38bac9e14971ecd9/gluten-core/src/main/scala/io/glutenproject/extension/columnar/TransformHintRule.scala#L156-L165
https://github.com/oap-project/gluten/blob/305924a19025f5ff0a65de0d38bac9e14971ecd9/gluten-core/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala#L160-L170

The text was updated successfully, but these errors were encountered:

dcoliversun added the enhancement label

dcoliversun mentioned this issue

[GLUTEN-3979][CORE] Use exists() instead of map().exists() to improve code readability #3980

Merged

ulysses-you closed this as completed in #3980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment