Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3979][CORE] Use exists() instead of map().exists() to improve code readability #3980

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

dcoliversun
Copy link
Contributor

What changes were proposed in this pull request?

(Fixes: #3979)

How was this patch tested?

Origin unit test

Copy link

github-actions bot commented Dec 8, 2023

#3979

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

@dcoliversun
Copy link
Contributor Author

@ulysses-you thanks for your review, and all checks passed. Ready to merge :)

@ulysses-you ulysses-you merged commit fb7c48e into apache:main Dec 8, 2023
17 checks passed
@dcoliversun dcoliversun deleted the GLUTEN-3979 branch December 8, 2023 08:36
@LuciferYang
Copy link

late lgtm

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3980_time.csv log/native_master_12_07_2023_9c5314fd5_time.csv difference percentage
q1 33.30 33.97 0.663 101.99%
q2 24.62 24.95 0.326 101.33%
q3 38.02 37.91 -0.115 99.70%
q4 37.44 37.39 -0.048 99.87%
q5 72.13 71.30 -0.825 98.86%
q6 5.35 5.38 0.028 100.52%
q7 85.53 85.81 0.281 100.33%
q8 85.43 85.80 0.367 100.43%
q9 123.55 123.51 -0.046 99.96%
q10 44.26 45.87 1.604 103.62%
q11 19.91 20.29 0.383 101.92%
q12 26.30 26.73 0.431 101.64%
q13 46.26 45.73 -0.531 98.85%
q14 19.83 16.69 -3.133 84.20%
q15 27.59 28.46 0.875 103.17%
q16 15.56 15.56 -0.010 99.94%
q17 103.09 103.37 0.276 100.27%
q18 149.69 149.01 -0.673 99.55%
q19 13.00 12.84 -0.156 98.80%
q20 27.95 27.78 -0.171 99.39%
q21 222.42 223.73 1.307 100.59%
q22 13.38 13.39 0.009 100.07%
total 1234.62 1235.47 0.842 100.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Use exists() instead of map().exists() to improve code readability
4 participants