-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] prefer to use static packaging #4942
Comments
We may mention this in dev maillist. static build makes the deployment much easier. The only issue may be the jar size but now even with debug info, it's just ~88MB. For developer with current build script, all static library will only be built once. Or build again after vcpkg script changed. velox will be built when commit id changed. So not an issue to development either. It may increase the link time somehow. See if anyone have concerns about this. |
Hi Rex, yes, will add the maillist to the doc, thanks! Thanks, |
FYI.
|
|
I have an another issue about libarrow.so. It seems similar with @PHILO-HE |
@ulysses-you the issue should be fixed by using static building libarrow.so/libparquet.so, will try to fix this in Thanks, |
thank you @zhouyuan ! |
We can provide options to choose building static or dynamic artifacts, and enable static by default. Just not force ban dynamic packaging directly, thank you. |
Description
The dynamic packaging will make a jar with all necessary dependencies for shared libs. On gluten start it will try to extract the libs and then load into JVM.
This method is introduced in early stage of Gluten. The production env is quite different: Cent7, Cent8, Ubuntu 20, Debian, ArchLinux and some customized Linux releases. For different OS the dependencies are different, especially on the library path and the library versions. The code is quite difficult to maintain as Velox is bumping the dependencies.
For better packaging releasing/maintaining, gluten may should pick the static packaging(vcpkg based) so all dependencies are all statically linked and can work on all OS.
Edit:
We need to keep the dynamic packaging method as it's already used in some production env.
CC: @weiting-chen
Thanks,
-yuan
The text was updated successfully, but these errors were encountered: