-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-4917][VL] static packaging refine #5033
base: main
Are you sure you want to change the base?
Conversation
9b59d82
to
7d95f2b
Compare
@zhouyuan Does this pr ready ? |
Hi @ulysses-you This patch adds the arrow build in vcpkg. it's not full ready for your case yet. The gap is:
the first patch may need some discussion with velox community. I'll try to do some tests in my own branch first. Thanks, |
thank you @zhouyuan ! |
4525398
to
9d4e893
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
This reverts commit 27856a1.
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
This reverts commit 3d8f4cc.
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
f082dc3
to
ba178c4
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
ba178c4
to
e8aae1d
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Velox is able to find the pre-built arrow with 6b0fb02 |
hi @zhouyuan if there any blocker on this ? |
hi Xiduo, we are actually breaking up this patch into smaller ones to get merged. still following on this. The first half is merged already however we do find some unit tests failed due to the new compile method. For static building with arrow and parquet(the second half of this patch) it's working on local test. However it requires to modify the library loading code path - which is actually conflicting with the original dynamic packaging method(as we still need to load libarrow/libparquet there). We may need to keep the both code path for a while as static packaging is not verified in production env. thanks |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
What changes were proposed in this pull request?
refine the static package in vcpkg
How was this patch tested?
pass GHA static build test