Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gluten-986] Rename metrics name from wall nanos to totaltime to xxx. #1034

Merged
merged 3 commits into from
Mar 1, 2023
Merged

[Gluten-986] Rename metrics name from wall nanos to totaltime to xxx. #1034

merged 3 commits into from
Mar 1, 2023

Conversation

Yohahaha
Copy link
Contributor

Mentioned in #987

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@Yohahaha Yohahaha changed the title Rename metrics name from wall nanos to totaltime to xxx. [Gluten-core] Rename metrics name from wall nanos to totaltime to xxx. Feb 27, 2023
@zhztheplayer
Copy link
Member

The CI failure during step Setup docker container might not be related. A fix proposed at #1036

@Yohahaha
Copy link
Contributor Author

cc @FelixYBW @rui-mo

@rui-mo
Copy link
Contributor

rui-mo commented Feb 27, 2023

@Yohahaha Thank you. We find cpu count is also useful to us, and can be used to calculte the avg time. Could you help add that back?

@Yohahaha
Copy link
Contributor Author

Yohahaha commented Feb 27, 2023 •
edited
Loading

We find cpu count is also useful to us, and can be used to calculte the avg time. Could you help add that back?

Sure, submit commit in this pr or open another pr?

How do you calculate avg time? cpu_time / cpu_count or wall_time / cpu_count? @rui-mo

@rui-mo
Copy link
Contributor

rui-mo commented Feb 27, 2023

Sure, submit commit in this pr or open another pr?

@Yohahaha Both work for us. Thank you.

cpu_time / cpu_count or wall_time / cpu_count?

I think wall_time is more useful to us.

@Yohahaha
Copy link
Contributor Author

Yohahaha commented Feb 27, 2023 •
edited
Loading

cpu_time / cpu_count or wall_time / cpu_count?

I think wall_time is more useful to us.

Got it.

It looks like cpu time is not important for us currently, and from Spark's point of view it is also unimportant, shall we remove this to make Spark UI more clearly? @rui-mo

@Yohahaha Yohahaha changed the title [Gluten-core] Rename metrics name from wall nanos to totaltime to xxx. [Gluten-986] Rename metrics name from wall nanos to totaltime to xxx. Feb 27, 2023
@github-actions
Copy link

#986

@rui-mo
Copy link
Contributor

rui-mo commented Feb 27, 2023

It looks like cpu time is not important for us currently, and from Spark's point of view it is also unimportant, shall we remove this to make Spark UI more clearly? @rui-mo

@FelixYBW Binwei, how do you think so?

@FelixYBW
Copy link
Contributor

OK, let's remove cpu time, use wall time.

@rui-mo rui-mo merged commit fa6698c into apache:main Mar 1, 2023
zhli1142015 pushed a commit to zhli1142015/gluten that referenced this pull request Mar 5, 2023
@Yohahaha
[Gluten-986] Rename metrics name from wall nanos to totaltime to xxx. (…
90cef86 
…apache#1034)

* Rename wall nanos to totaltime to xxx.

* Replace cpu time to cpu count.

---------

Co-authored-by: yangchuan <yangchuan.zy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixYBW FelixYBW FelixYBW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Yohahaha @zhztheplayer @rui-mo @FelixYBW