[GLUTEN-1985] avoid forceShuffledHashJoin when the join condition does not supported by the backend #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
e9db42a
to
65f41e3
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
65f41e3
to
161d454
Compare
|
Run Gluten Clickhouse CI |
zzcclp
reviewed
Jun 16, 2023
| |""".stripMargin | ||
|
|
||
| val df = spark.sql(testSql) | ||
| val sortMergeJoinExecTransFormer = df.queryExecution.executedPlan.collect { |
There was a problem hiding this comment.
SortMergeJoinExecTransformer is not supported, maybe skip transform SMJ in transform rules.
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
161d454
to
92749e3
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
92749e3
to
8d0c547
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
8d0c547
to
7fe4e4c
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
7fe4e4c
to
c2be9d5
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
c2be9d5
to
57e1086
Compare
|
Run Gluten Clickhouse CI |
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
57e1086
to
f08ce5f
Compare
|
Run Gluten Clickhouse CI |
…s not supported by the backend
zheniantoushipashi
force-pushed
the
GLUTEN-1985
branch
from
f08ce5f
to
63e3070
Compare
|
Run Gluten Clickhouse CI |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In our custom JoinSelectionOverrides rule, if forceShuffledHashJoin is set to true, SortmergeJoin will be converted to ShuffledHashJoin regardless of whether the backend supports it or whether it is fallback. If it is executed in spark in the case of falllback, SortmergeJoin will be converted For ShuffledHashJoin, it will take up more memory, resulting in OOM,
Describe the solution you'd like
avoid forceShuffledHashJoin when the join condition does not supported by the backend