[GLUTEN-3361]Fix the compile issue caused by wrong Empty2Null package in spark 3.4 #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
JkSelf
changed the title
|
Verified. Thanks! |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the following compile issue when using
mvn clean install -Pbackends-velox -Prss -Pspark-3.4 -DskipTestscommand.[ERROR] /home/sparkuser/workspace/workspace/Gluten_Perf_ICX/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionMappings.scala:28: error: value Empty2Null is not a member of object org.apache.spark.sql.execution.datasources.FileFormatWriter [ERROR] import org.apache.spark.sql.execution.datasources.FileFormatWriter.Empty2Null [ERROR] ^ [WARNING] /home/sparkuser/workspace/workspace/Gluten_Perf_ICX/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionMappings.scala:28: warning: Unused import [WARNING] import org.apache.spark.sql.execution.datasources.FileFormatWriter.Empty2Null [WARNING] ^ [WARNING] one warning found [ERROR] one error found [ERROR] exception compilation error occurred!!! org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166) at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:153) at scala_maven_executions.JavaMainCallerByFork.run (JavaMainCallerByFork.java:95) at scala_maven.ScalaCompilerSupport.compile (ScalaCompilerSupport.java:173) at scala_maven.ScalaCompilerSupport.doExecute (ScalaCompilerSupport.java:86) at scala_maven.ScalaMojoSupport.execute (ScalaMojoSupport.java:310) at scala_maven.ScalaCompileMojo.execute (ScalaCompileMojo.java:108) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)How was this patch tested?
Existing unit test.