Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Break up spilling operation to two phases: shrink phase and spill phase #3895

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

zhztheplayer
Copy link
Member

This will make sure the memory manager shrinks all unused reservations before calling a spiller's spill() method. shrink() must be called before spill() since the latter costs computation and IO resources much higher than the former.

@zhztheplayer zhztheplayer marked this pull request as draft November 30, 2023 09:22
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer
Copy link
Member Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3895_time.csv log/native_master_11_29_2023_0ac1dc42d_time.csv difference percentage
q1 33.95 34.61 0.661 101.95%
q2 24.32 24.87 0.555 102.28%
q3 37.86 36.61 -1.253 96.69%
q4 38.08 36.91 -1.175 96.91%
q5 70.01 71.43 1.421 102.03%
q6 7.24 7.22 -0.015 99.79%
q7 86.47 85.50 -0.966 98.88%
q8 87.57 88.07 0.501 100.57%
q9 128.11 127.33 -0.780 99.39%
q10 45.96 44.31 -1.647 96.42%
q11 20.14 20.45 0.313 101.55%
q12 25.69 27.02 1.331 105.18%
q13 46.48 46.05 -0.426 99.08%
q14 17.79 18.98 1.188 106.68%
q15 29.06 29.21 0.145 100.50%
q16 15.37 15.65 0.281 101.83%
q17 103.09 101.75 -1.347 98.69%
q18 150.49 150.75 0.260 100.17%
q19 12.91 13.94 1.035 108.02%
q20 28.23 30.32 2.096 107.43%
q21 224.16 225.21 1.048 100.47%
q22 13.10 13.20 0.101 100.77%
total 1246.06 1249.39 3.325 100.27%

Copy link

github-actions bot commented Dec 1, 2023

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review December 1, 2023 03:24
@zhztheplayer
Copy link
Member Author

@JkSelf @zhouyuan

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zhztheplayer zhztheplayer merged commit c926725 into apache:main Dec 1, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3895_time.csv log/native_master_11_30_2023_d2980b73a_time.csv difference percentage
q1 35.12 32.81 -2.302 93.44%
q2 24.89 26.03 1.145 104.60%
q3 38.43 37.62 -0.818 97.87%
q4 37.09 37.38 0.286 100.77%
q5 72.02 72.32 0.296 100.41%
q6 6.65 6.56 -0.096 98.56%
q7 85.67 86.62 0.945 101.10%
q8 85.46 87.07 1.609 101.88%
q9 123.13 126.83 3.698 103.00%
q10 46.25 47.00 0.753 101.63%
q11 19.91 20.00 0.087 100.44%
q12 27.94 25.82 -2.123 92.40%
q13 45.45 46.37 0.922 102.03%
q14 17.43 16.00 -1.423 91.83%
q15 28.44 27.70 -0.732 97.43%
q16 15.37 15.45 0.084 100.55%
q17 101.46 102.12 0.669 100.66%
q18 150.92 150.61 -0.305 99.80%
q19 13.00 12.85 -0.148 98.86%
q20 27.31 27.48 0.166 100.61%
q21 225.20 226.90 1.696 100.75%
q22 13.20 13.04 -0.163 98.76%
total 1240.34 1244.58 4.248 100.34%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants