Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3906] [VL] fix: fix package.sh failed for x86 #3907

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

lzjqsdd
Copy link
Contributor

@lzjqsdd lzjqsdd commented Dec 1, 2023

package.sh export CPU_ARCH env from 'uname -m' , this will get x86_64 for intel platform。 velox need CPU_ARCH for aarch64/aarch64/avx/sse, this will cause velox build fmt dependency failed 。 Velox will automatically check CPU_ARCH environment if not specified

Fix: #3906

Copy link

github-actions bot commented Dec 1, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@lzjqsdd lzjqsdd changed the title [VL] [CI] remove CPU_TARGET in package.sh [GLUTEN-3906] [VL] fix: fix package.sh failed for x86 Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

#3906

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 1, 2023

@lzjqsdd thank fix for the fix. This is introduced in recent Velox changes - didn't got a chance to fix it.

CC: @weiting-chen

@zhouyuan zhouyuan merged commit 5580393 into apache:main Dec 2, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3907_time.csv log/native_master_12_01_2023_26fc88744_time.csv difference percentage
q1 34.58 33.86 -0.723 97.91%
q2 25.06 25.15 0.094 100.37%
q3 38.46 38.03 -0.436 98.87%
q4 36.09 37.46 1.378 103.82%
q5 71.54 72.27 0.722 101.01%
q6 6.64 7.31 0.678 110.22%
q7 84.28 84.79 0.514 100.61%
q8 88.08 87.41 -0.664 99.25%
q9 126.88 123.56 -3.318 97.38%
q10 43.48 43.60 0.121 100.28%
q11 20.31 20.18 -0.128 99.37%
q12 26.96 27.60 0.646 102.40%
q13 46.70 46.11 -0.598 98.72%
q14 14.55 14.72 0.169 101.16%
q15 29.28 29.45 0.172 100.59%
q16 15.18 15.59 0.412 102.71%
q17 102.76 102.69 -0.066 99.94%
q18 150.82 149.73 -1.088 99.28%
q19 12.75 12.85 0.106 100.83%
q20 27.46 27.94 0.480 101.75%
q21 223.60 225.25 1.657 100.74%
q22 12.93 13.32 0.396 103.06%
total 1238.37 1238.89 0.524 100.04%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_02_2023_time.csv log/native_master_12_01_2023_26fc88744_time.csv difference percentage
q1 33.99 33.86 -0.127 99.63%
q2 25.09 25.15 0.059 100.24%
q3 37.78 38.03 0.249 100.66%
q4 37.53 37.46 -0.065 99.83%
q5 70.23 72.27 2.040 102.91%
q6 7.14 7.31 0.173 102.42%
q7 86.71 84.79 -1.918 97.79%
q8 86.65 87.41 0.766 100.88%
q9 120.74 123.56 2.827 102.34%
q10 45.96 43.60 -2.359 94.87%
q11 20.30 20.18 -0.118 99.42%
q12 24.61 27.60 2.993 112.16%
q13 45.54 46.11 0.570 101.25%
q14 17.74 14.72 -3.021 82.97%
q15 27.53 29.45 1.918 106.97%
q16 15.58 15.59 0.017 100.11%
q17 101.84 102.69 0.847 100.83%
q18 150.15 149.73 -0.415 99.72%
q19 12.97 12.85 -0.116 99.11%
q20 27.75 27.94 0.188 100.68%
q21 225.81 225.25 -0.554 99.75%
q22 13.17 13.32 0.158 101.20%
total 1234.78 1238.89 4.112 100.33%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_03_2023_time.csv log/native_master_12_02_2023_558039323_time.csv difference percentage
q1 34.07 33.99 -0.083 99.76%
q2 24.77 25.09 0.318 101.29%
q3 37.57 37.78 0.206 100.55%
q4 37.63 37.53 -0.104 99.72%
q5 71.98 70.23 -1.759 97.56%
q6 7.08 7.14 0.062 100.88%
q7 85.82 86.71 0.890 101.04%
q8 87.36 86.65 -0.714 99.18%
q9 123.46 120.74 -2.720 97.80%
q10 45.50 45.96 0.461 101.01%
q11 19.71 20.30 0.585 102.97%
q12 28.46 24.61 -3.851 86.47%
q13 46.75 45.54 -1.211 97.41%
q14 13.79 17.74 3.948 128.64%
q15 27.74 27.53 -0.203 99.27%
q16 15.40 15.58 0.179 101.16%
q17 102.03 101.84 -0.185 99.82%
q18 150.05 150.15 0.095 100.06%
q19 12.97 12.97 -0.004 99.97%
q20 27.88 27.75 -0.131 99.53%
q21 225.84 225.81 -0.037 99.98%
q22 13.46 13.17 -0.299 97.78%
total 1239.34 1234.78 -4.556 99.63%

@lzjqsdd lzjqsdd deleted the fix-velox-ci branch December 4, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] dev/package.sh build failed for x86 cause by CPU_ARCH env not correct
3 participants