[GLUTEN-3854][CORE][FOLLOWUP] Add ColumnarInputAdapter back to recover UI graph #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
cc @zhztheplayer thank you |
zhztheplayer
reviewed
Dec 6, 2023
Comment on lines
80
to
113
| // This is not strictly needed because the codegen transformation happens after the columnar | ||
| // transformation but just for consistency | ||
| override def supportsColumnar: Boolean = child.supportsColumnar | ||
|
|
||
| // this is the most important effect of this class | ||
| override def supportCodegen: Boolean = false | ||
|
|
||
| override def doExecuteColumnar(): RDD[ColumnarBatch] = { | ||
| child.executeColumnar() | ||
| } | ||
|
|
||
| override def nodeName: String = s"InputAdapter" | ||
|
|
||
| override def generateTreeString( | ||
| depth: Int, | ||
| lastChildren: Seq[Boolean], | ||
| append: String => Unit, | ||
| verbose: Boolean, | ||
| prefix: String = "", | ||
| addSuffix: Boolean = false, | ||
| maxFields: Int, | ||
| printNodeId: Boolean, | ||
| indent: Int = 0): Unit = { | ||
| child.generateTreeString( | ||
| depth, | ||
| lastChildren, | ||
| append, | ||
| verbose, | ||
| prefix = "", | ||
| addSuffix = false, | ||
| maxFields, | ||
| printNodeId, | ||
| indent) | ||
| } |
There was a problem hiding this comment.
It seems that we only need to override #supportCodegen ? Can we remove others to simply code? Thanks!
|
Run Gluten Clickhouse CI |
ulysses-you
force-pushed
the
input-adapter
branch
from
b3d995f
to
d6d6eb5
Compare
|
Run Gluten Clickhouse CI |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is followup fix of #3854. We can not remove
ColumnarInputAdapter, otherwise the UI graph would be broken.How was this patch tested?
before:
after:
