Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] quick fix for static build git conflict #3971

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Dec 7, 2023

What changes were proposed in this pull request?

not necessary to install git236

How was this patch tested?

pass GHA

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Dec 7, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan changed the title [VL] fix static build [VL] fix static build git conflict Dec 7, 2023
@zhouyuan zhouyuan changed the title [VL] fix static build git conflict [VL] quick fix for static build git conflict Dec 7, 2023
@zhouyuan zhouyuan marked this pull request as ready for review December 8, 2023 00:55
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PHILO-HE PHILO-HE merged commit 1b87ae9 into apache:main Dec 8, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3971_time.csv log/native_master_12_07_2023_9c5314fd5_time.csv difference percentage
q1 33.53 33.97 0.438 101.31%
q2 25.14 24.95 -0.195 99.23%
q3 38.78 37.91 -0.873 97.75%
q4 36.65 37.39 0.745 102.03%
q5 70.69 71.30 0.610 100.86%
q6 7.12 5.38 -1.740 75.56%
q7 83.29 85.81 2.521 103.03%
q8 88.26 85.80 -2.461 97.21%
q9 124.17 123.51 -0.659 99.47%
q10 43.48 45.87 2.388 105.49%
q11 21.19 20.29 -0.901 95.75%
q12 27.88 26.73 -1.155 95.86%
q13 46.81 45.73 -1.073 97.71%
q14 16.75 16.69 -0.056 99.66%
q15 28.91 28.46 -0.447 98.45%
q16 15.38 15.56 0.173 101.13%
q17 102.42 103.37 0.952 100.93%
q18 148.89 149.01 0.127 100.09%
q19 12.91 12.84 -0.069 99.47%
q20 27.26 27.78 0.519 101.90%
q21 222.52 223.73 1.215 100.55%
q22 13.14 13.39 0.251 101.91%
total 1235.16 1235.47 0.310 100.03%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants