[VL] Explode support Literal array and map #4019
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
liujiayi771
changed the title
|
@zhouyuan Could you help to review? |
There was a problem hiding this comment.
@liujiayi771 thanks for helping on this. Just not sure if the nested type is considered.
| unnestNames.emplace_back(fmt::format("C{}", unnestIndex++)); | ||
| } else { | ||
| VELOX_FAIL( | ||
| "Unexpected type of unnest variable. Expected ARRAY or MAP, but got {}.", variable->type()->toString()); |
There was a problem hiding this comment.
nit: can we also apply this check logic in native validation?
There was a problem hiding this comment.
This is actually already limited in Spark's Explode, which only supports map and array types.
| } | ||
| runQueryAndCompare(""" | ||
| |SELECT explode(map(1, 'a', 2, 'b')); | ||
| |""".stripMargin) { |
There was a problem hiding this comment.
nit: can you please also add a test for nested array/map? I'm not sure if this would work.
e.g. array(map(1, "2"))
There was a problem hiding this comment.
Yes, it can be executed normally, and two nested test cases have been added.
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
After my tests, I have found that the Velox backend does support the explode function for Literal inputs of both array and map types. We can lift the restrictions on validation.
How was this patch tested?
Add a test case in
TestOperator.