Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4036][CH] Lazy intialize the CHStreamReader in shuffle read, avoid OOM #4037

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

lgbo-ustc
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #4036

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

#4036

Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc force-pushed the oom_empty_shuffle_input_stream branch from e1780cd to cf5a62d Compare December 14, 2023 04:18
Copy link

Run Gluten Clickhouse CI

@liuneng1994
Copy link
Contributor

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 37c1d77 into apache:main Dec 15, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4037_time.csv log/native_master_12_14_2023_ee48260b2_time.csv difference percentage
q1 32.60 34.04 1.439 104.41%
q2 25.21 25.15 -0.060 99.76%
q3 36.23 38.55 2.322 106.41%
q4 39.21 38.97 -0.240 99.39%
q5 72.31 69.87 -2.436 96.63%
q6 6.78 7.26 0.480 107.09%
q7 85.17 83.73 -1.444 98.30%
q8 87.80 87.27 -0.523 99.40%
q9 124.62 129.00 4.377 103.51%
q10 44.66 45.30 0.641 101.43%
q11 20.57 20.20 -0.372 98.19%
q12 27.26 26.45 -0.818 97.00%
q13 47.03 45.94 -1.090 97.68%
q14 15.55 15.02 -0.529 96.60%
q15 28.28 27.17 -1.105 96.09%
q16 15.42 15.59 0.173 101.12%
q17 102.32 102.60 0.278 100.27%
q18 150.77 150.13 -0.637 99.58%
q19 12.74 12.82 0.088 100.69%
q20 28.11 27.14 -0.974 96.54%
q21 228.99 225.86 -3.132 98.63%
q22 14.87 14.42 -0.450 96.97%
total 1246.48 1242.47 -4.012 99.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] CHCelebornColumnarBatchSerializerInstance consumes too much memory on empty streams
3 participants