Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4044] [VL] Pass asLowerCase for complex types parsing #4045

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Dec 14, 2023

What changes were proposed in this pull request?

Fixes: #4044.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

#4044

@zhli1142015
Copy link
Contributor Author

cc @rui-mo , @zhouyuan

@zhli1142015
Copy link
Contributor Author

cc @sezruby and @felipepessoto also.

Copy link
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@rui-mo rui-mo merged commit f5b1f92 into apache:main Dec 15, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4045_time.csv log/native_master_12_14_2023_ee48260b2_time.csv difference percentage
q1 35.23 34.04 -1.185 96.64%
q2 25.01 25.15 0.139 100.56%
q3 38.60 38.55 -0.055 99.86%
q4 39.27 38.97 -0.303 99.23%
q5 72.47 69.87 -2.596 96.42%
q6 5.42 7.26 1.837 133.90%
q7 85.56 83.73 -1.835 97.86%
q8 86.85 87.27 0.423 100.49%
q9 128.57 129.00 0.427 100.33%
q10 43.70 45.30 1.604 103.67%
q11 20.94 20.20 -0.739 96.47%
q12 24.65 26.45 1.793 107.27%
q13 46.77 45.94 -0.836 98.21%
q14 15.17 15.02 -0.154 98.99%
q15 29.20 27.17 -2.031 93.05%
q16 15.33 15.59 0.259 101.69%
q17 102.70 102.60 -0.105 99.90%
q18 153.35 150.13 -3.217 97.90%
q19 14.44 12.82 -1.617 88.80%
q20 28.03 27.14 -0.895 96.81%
q21 226.70 225.86 -0.847 99.63%
q22 14.08 14.42 0.343 102.43%
total 1252.06 1242.47 -9.591 99.23%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delta checkpoint loading failed in 'checkColumnNameLowerCase'
3 participants