Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Error "Mutable config cannot return unprotected reference to values" when reading from S3 #4079

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Dec 18, 2023

23/12/17 20:54:26 WARN TaskSetManager: Lost task 0.1 in stage 32.0 (TID 11949) (sr270 executor 10): io.glutenproject.exception.GlutenException: java.lang.RuntimeException: Exception: VeloxUserError
Error Source: USER
Error Code: UNSUPPORTED
Reason: Mutable config cannot return unprotected reference to values.
Retriable: False
Context: Split [Hive: s3a://tpcds/t_tpcds_part_1_stringdate/store/part-00000-3502e042-fa34-42ed-bf8e-cb5f60cfebf0-c000.snappy.parquet 0 - 9653] Task Gluten_Stage_32_TID_11949
Top-Level Context: Same as context.
Function: values
File: ../.././velox/core/Config.h
Line: 114
Stack trace:
# 0  facebook::velox::VeloxException::VeloxException(char const*, unsigned long, char const*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, bool, facebook::velox::VeloxException::Type, std::basic_string_view<char, std::char_traits<char> >)
# 1  void facebook::velox::detail::veloxCheckFail<facebook::velox::VeloxUserError, char const*>(facebook::velox::detail::VeloxCheckFailArgs const&, char const*)
# 2  0x0000000000000000
# 3  facebook::velox::filesystems::S3FileSystem::Impl::Impl(facebook::velox::Config const*)
# 4  facebook::velox::filesystems::S3FileSystem::S3FileSystem(std::shared_ptr<facebook::velox::Config const>)
# 5  void folly::basic_once_flag<folly::SharedMutexImpl<false, void, std::atomic, folly::SharedMutexPolicyDefault>, std::atomic>::call_once_slow<facebook::velox::filesystems::fileSystemGenerator()::{lambda(std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >)#1}::operator()(std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >) const::{lambda()#1}>(facebook::velox::filesystems::fileSystemGenerator()::{lambda(std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >)#1}::operator()(std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >) const::{lambda()#1}&&) [clone .constprop.0]
# 6  std::_Function_handler<std::shared_ptr<facebook::velox::filesystems::FileSystem> (std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >), facebook::velox::filesystems::fileSystemGenerator()::{lambda(std::shared_ptr<facebook::velox::Config const>, std::basic_string_view<char, std::char_traits<char> >)#1}>::_M_invoke(std::_Any_data const&, std::shared_ptr<facebook::velox::Config const>&&, std::basic_string_view<char, std::char_traits<char> >&&)
# 7  facebook::velox::filesystems::getFileSystem(std::basic_string_view<char, std::char_traits<char> >, std::shared_ptr<facebook::velox::Config const>)
# 8  facebook::velox::FileHandleGenerator::operator()(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
# 9  facebook::velox::CachedFactory<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::shared_ptr<facebook::velox::FileHandle>, facebook::velox::FileHandleGenerator>::generate(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
# 10 facebook::velox::connector::hive::HiveDataSource::addSplit(std::shared_ptr<facebook::velox::connector::ConnectorSplit>)
# 11 facebook::velox::exec::TableScan::getOutput()
# 12 facebook::velox::exec::Driver::runInternal(std::shared_ptr<facebook::velox::exec::Driver>&, std::shared_ptr<facebook::velox::exec::BlockingState>&, std::shared_ptr<facebook::velox::RowVector>&)
# 13 facebook::velox::exec::Driver::next(std::shared_ptr<facebook::velox::exec::BlockingState>&)
# 14 facebook::velox::exec::Task::next(folly::SemiFuture<folly::Unit>*)
# 15 gluten::WholeStageResultIterator::next()
# 16 Java_io_glutenproject_vectorized_ColumnarBatchOutIterator_nativeHasNext
# 17 0x00007fd6283ad6c7

This might be related to facebookincubator/velox#8083

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit 7dafdb1 into apache:main Dec 19, 2023
15 of 16 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4079_time.csv log/native_master_12_18_2023_ecf765da9_time.csv difference percentage
q1 33.59 33.40 -0.190 99.43%
q2 24.59 24.92 0.330 101.34%
q3 37.83 39.07 1.238 103.27%
q4 39.33 39.68 0.345 100.88%
q5 71.89 72.52 0.626 100.87%
q6 6.29 7.08 0.789 112.54%
q7 86.32 85.20 -1.124 98.70%
q8 86.34 87.23 0.889 101.03%
q9 120.38 127.21 6.835 105.68%
q10 45.53 45.48 -0.051 99.89%
q11 19.59 19.88 0.295 101.51%
q12 27.18 25.92 -1.257 95.37%
q13 46.37 46.99 0.626 101.35%
q14 18.92 15.90 -3.019 84.05%
q15 27.88 30.75 2.870 110.29%
q16 16.17 15.88 -0.290 98.21%
q17 102.58 103.20 0.616 100.60%
q18 151.39 151.92 0.522 100.34%
q19 14.46 12.96 -1.495 89.66%
q20 27.76 28.35 0.593 102.14%
q21 227.15 229.29 2.141 100.94%
q22 13.89 13.82 -0.072 99.48%
total 1245.43 1256.65 11.216 100.90%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants