[VL] Use partial companion functions for distinct aggregation #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
rui-mo
changed the title
Comment on lines
+177
to
+184
| super.modeToKeyWord(if (mixedPartialAndMerge) { | ||
| Partial | ||
| } else { | ||
| aggregateMode match { | ||
| case PartialMerge => Final | ||
| case _ => aggregateMode | ||
| } | ||
| }) |
There was a problem hiding this comment.
Can we use Final for all aggregate modes?
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Flush of intermediate aggregation needs to be disabled if it is used for distinct computing. But disabling flushing is tricky because doing so will require enabling spilling. In this PR, we use partial companion functions instead to make sure that final aggregation returns "intermediate" results.
oap-project/velox#465
How was this patch tested?
Verfied on Jenkins.