[GLUTEN-4151][VL] initialize local&hdfs file write sink with FileSink::create function #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::create function
|
cc @yma11 It would be nice if you have time to review this |
yma11
reviewed
Dec 26, 2023
| auto path = filePath_.substr(5); | ||
| auto localWriteFile = std::make_unique<LocalWriteFile>(path, true, false); | ||
| sink_ = std::make_unique<WriteFileSink>(std::move(localWriteFile), path); | ||
| sink_ = dwio::common::FileSink::create(filePath_, {.pool = pool_.get()}); |
There was a problem hiding this comment.
pool should not be needed for localFileSink and hdfsFileSink. You can take a check at velox layer.
There was a problem hiding this comment.
Correct me if I'm wrong. I refer velox code to initialize the sink, could you please share velox layer?
There was a problem hiding this comment.
Yes. Seems pool is always provided in velox's usage even it's not actually used.
yma11
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The WriteFileSink is not the API Velox supposed to expose, we need to initialize local&hdfs file write sink with FileSink::create function.
(Fixes: #4151)
How was this patch tested?
Original unit test in GA.