Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Query hangs on destroying memory manager #4232

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

zhztheplayer
Copy link
Member

This is a fix for recent Velox change facebookincubator/velox@e6f84e8.

CI was broken so didn't produce the issue.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer zhztheplayer changed the title [VL] Query hang on destroying memory manager [VL] Query hangs on destroying memory manager Dec 29, 2023
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit fcb31fc into apache:main Dec 29, 2023
21 of 35 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4232_time.csv log/native_master_12_28_2023_2cea5a309_time.csv difference percentage
q1 33.36 31.38 -1.989 94.04%
q2 25.07 24.91 -0.151 99.40%
q3 38.21 37.89 -0.317 99.17%
q4 39.25 38.93 -0.318 99.19%
q5 71.82 72.12 0.293 100.41%
q6 5.40 7.16 1.756 132.52%
q7 85.22 86.15 0.936 101.10%
q8 87.09 88.01 0.917 101.05%
q9 126.92 124.44 -2.481 98.05%
q10 44.88 43.66 -1.223 97.27%
q11 19.73 20.24 0.503 102.55%
q12 26.08 27.81 1.731 106.64%
q13 46.26 46.28 0.018 100.04%
q14 15.23 14.69 -0.540 96.45%
q15 29.74 30.44 0.695 102.34%
q16 15.30 15.32 0.026 100.17%
q17 102.31 103.59 1.279 101.25%
q18 150.69 152.40 1.714 101.14%
q19 12.70 13.94 1.241 109.78%
q20 26.93 26.83 -0.100 99.63%
q21 225.42 227.09 1.666 100.74%
q22 13.87 14.05 0.179 101.29%
total 1241.48 1247.31 5.834 100.47%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_30_2023_time.csv log/native_master_12_28_2023_2cea5a309_time.csv difference percentage
q1 32.76 31.38 -1.387 95.77%
q2 26.34 24.91 -1.425 94.59%
q3 37.74 37.89 0.152 100.40%
q4 37.79 38.93 1.144 103.03%
q5 71.74 72.12 0.375 100.52%
q6 6.96 7.16 0.198 102.84%
q7 86.77 86.15 -0.620 99.29%
q8 86.46 88.01 1.553 101.80%
q9 125.73 124.44 -1.296 98.97%
q10 45.46 43.66 -1.806 96.03%
q11 20.01 20.24 0.226 101.13%
q12 26.77 27.81 1.037 103.88%
q13 46.33 46.28 -0.046 99.90%
q14 16.07 14.69 -1.379 91.42%
q15 28.03 30.44 2.403 108.57%
q16 15.55 15.32 -0.225 98.55%
q17 103.02 103.59 0.566 100.55%
q18 150.94 152.40 1.462 100.97%
q19 13.85 13.94 0.088 100.64%
q20 27.04 26.83 -0.213 99.21%
q21 223.34 227.09 3.753 101.68%
q22 13.91 14.05 0.137 100.98%
total 1242.62 1247.31 4.697 100.38%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_30_2023_time.csv log/native_master_12_30_2023_fcb31fc6b_time.csv difference percentage
q1 33.05 32.76 -0.285 99.14%
q2 25.25 26.34 1.095 104.34%
q3 38.60 37.74 -0.861 97.77%
q4 38.95 37.79 -1.164 97.01%
q5 72.40 71.74 -0.663 99.08%
q6 5.40 6.96 1.557 128.84%
q7 85.25 86.77 1.521 101.78%
q8 87.59 86.46 -1.134 98.70%
q9 126.15 125.73 -0.418 99.67%
q10 44.16 45.46 1.305 102.96%
q11 20.02 20.01 -0.007 99.96%
q12 24.90 26.77 1.867 107.50%
q13 46.38 46.33 -0.051 99.89%
q14 18.96 16.07 -2.891 84.75%
q15 28.59 28.03 -0.563 98.03%
q16 15.52 15.55 0.031 100.20%
q17 102.93 103.02 0.091 100.09%
q18 153.88 150.94 -2.940 98.09%
q19 12.72 13.85 1.126 108.85%
q20 27.00 27.04 0.049 100.18%
q21 228.65 223.34 -5.316 97.67%
q22 14.05 13.91 -0.138 99.01%
total 1250.41 1242.62 -7.791 99.38%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_31_2023_time.csv log/native_master_12_30_2023_fcb31fc6b_time.csv difference percentage
q1 32.90 33.05 0.145 100.44%
q2 24.93 25.25 0.317 101.27%
q3 37.84 38.60 0.759 102.01%
q4 39.87 38.95 -0.917 97.70%
q5 72.24 72.40 0.162 100.22%
q6 5.46 5.40 -0.059 98.92%
q7 86.25 85.25 -1.000 98.84%
q8 87.21 87.59 0.382 100.44%
q9 123.01 126.15 3.141 102.55%
q10 44.43 44.16 -0.275 99.38%
q11 20.20 20.02 -0.182 99.10%
q12 22.89 24.90 2.014 108.80%
q13 46.58 46.38 -0.205 99.56%
q14 14.53 18.96 4.435 130.53%
q15 29.52 28.59 -0.924 96.87%
q16 15.31 15.52 0.208 101.36%
q17 103.65 102.93 -0.717 99.31%
q18 151.51 153.88 2.372 101.57%
q19 12.75 12.72 -0.025 99.81%
q20 29.45 27.00 -2.452 91.67%
q21 224.98 228.65 3.675 101.63%
q22 15.74 14.05 -1.690 89.26%
total 1241.24 1250.41 9.166 100.74%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_01_01_2024_time.csv log/native_master_12_31_2023_fcb31fc6b_time.csv difference percentage
q1 34.09 32.90 -1.187 96.52%
q2 24.97 24.93 -0.039 99.84%
q3 38.31 37.84 -0.463 98.79%
q4 38.90 39.87 0.967 102.49%
q5 70.30 72.24 1.944 102.77%
q6 7.11 5.46 -1.646 76.83%
q7 86.69 86.25 -0.443 99.49%
q8 86.97 87.21 0.239 100.27%
q9 125.90 123.01 -2.891 97.70%
q10 46.03 44.43 -1.595 96.54%
q11 20.46 20.20 -0.260 98.73%
q12 28.23 22.89 -5.338 81.09%
q13 45.95 46.58 0.631 101.37%
q14 17.54 14.53 -3.018 82.80%
q15 28.69 29.52 0.824 102.87%
q16 16.88 15.31 -1.567 90.72%
q17 104.27 103.65 -0.628 99.40%
q18 151.07 151.51 0.435 100.29%
q19 12.72 12.75 0.032 100.25%
q20 27.40 29.45 2.048 107.47%
q21 226.10 224.98 -1.120 99.50%
q22 14.00 15.74 1.736 112.40%
total 1252.58 1241.24 -11.339 99.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants