Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3559][VL] Fix unit tests in GlutenSQLQueryTestSuite suite - Part 2 #4380

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

vibhaska
Copy link
Contributor

What changes were proposed in this pull request?

This PR enables following tests in the suite GlutenSQLQueryTestSuite:
"ilike-all.sql",
"ilike-any.sql",
"udf-window.sql",
"ansi/cast.sql",
"ansi/decimalArithmeticOperations.sql",
"ansi/map.sql",
"ansi/datetime-parsing-invalid.sql",
"ansi/string-functions.sql",
"ansi/interval.sql",
"ansi/date.sql",
"ansi/timestamp.sql",
"ansi/try_arithmetic.sql",
"ansi/literals.sql",
"timestampNTZ/timestamp-ansi.sql",
"timestampNTZ/timestamp.sql",
"udf/udf-intersect-all.sql - Scala UDF",
"udf/udf-except-all.sql - Scala UDF",
"udf/udf-udaf.sql - Scala UDF",
"udf/udf-group-by.sql - Scala UDF",
"udf/udf-except.sql - Scala UDF",
"udf/udf-pivot.sql - Scala UDF",
"udf/udf-inline-table.sql - Scala UDF",
"udf/postgreSQL/udf-select_having.sql - Scala UDF",
"typeCoercion/native/windowFrameCoercion.sql",
"typeCoercion/native/decimalPrecision.sql",
"typeCoercion/native/ifCoercion.sql",
"typeCoercion/native/dateTimeOperations.sql",
"typeCoercion/native/booleanEquality.sql",
"typeCoercion/native/mapZipWith.sql",
"typeCoercion/native/caseWhenCoercion.sql",
"typeCoercion/native/widenSetOperationTypes.sql",
"typeCoercion/native/promoteStrings.sql",
"typeCoercion/native/stringCastAndExpressions.sql",
"typeCoercion/native/inConversion.sql",
"typeCoercion/native/division.sql",
"typeCoercion/native/mapconcat.sql"

(Fixes: #3559)

How was this patch tested?

Ran this UT to confirm the fix

Copy link

#3559

Copy link

Run Gluten Clickhouse CI

@vibhaska
Copy link
Contributor Author

@JkSelf please review

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@JkSelf JkSelf merged commit 36c0ea0 into apache:main Jan 11, 2024
19 checks passed
@ulysses-you
Copy link
Contributor

Please take care the commit message before merging

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4380_time.csv log/native_master_01_12_2024_146b82f66_time.csv difference percentage
q1 32.78 31.64 -1.132 96.54%
q2 24.64 24.15 -0.494 98.00%
q3 38.49 37.87 -0.628 98.37%
q4 36.58 37.85 1.269 103.47%
q5 69.03 70.99 1.961 102.84%
q6 7.31 5.76 -1.541 78.91%
q7 83.99 84.88 0.890 101.06%
q8 86.83 87.55 0.718 100.83%
q9 123.65 122.67 -0.986 99.20%
q10 45.02 44.75 -0.269 99.40%
q11 21.04 20.07 -0.972 95.38%
q12 29.53 25.07 -4.459 84.90%
q13 46.60 48.13 1.532 103.29%
q14 18.76 19.37 0.610 103.25%
q15 32.12 30.96 -1.160 96.39%
q16 13.12 14.33 1.210 109.22%
q17 104.56 102.84 -1.719 98.36%
q18 147.64 148.14 0.501 100.34%
q19 13.72 13.67 -0.047 99.66%
q20 28.78 28.20 -0.582 97.98%
q21 226.93 225.09 -1.844 99.19%
q22 13.66 13.63 -0.035 99.75%
total 1244.80 1237.62 -7.177 99.42%

@vibhaska vibhaska deleted the ut_sqlQuery2 branch January 12, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Track all the failed unit test in Spark 3.4.
4 participants