Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3559][VL] Fix unit tests in GlutenParquetV1FilterSuite and GlutenParquetV2FilterSuite #4381

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

vibhaska
Copy link
Contributor

What changes were proposed in this pull request?

This PR enables following tests in the suite GlutenParquetV1FilterSuite and GlutenParquetV2FilterSuite: "filter pushdown - StringStartsWith"

Please note that #3559 has mentioned test 'filter pushdown - StringPredicate' but that's similar to "filter pushdown - StringStartsWith" of Spark33 and so will remain disabled (as similar test is disabled in Spark33).

(Fixes: #3559)

How was this patch tested?

Ran this UT to confirm the fix

Copy link

#3559

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@vibhaska
Copy link
Contributor Author

@JkSelf kindly review

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@vibhaska
Copy link
Contributor Author

@JkSelf @zhli1142015 Kindly review

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@JkSelf JkSelf merged commit 6a26ad7 into apache:main Jan 18, 2024
19 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4381_time.csv log/native_master_01_17_2024_6e070aee2_time.csv difference percentage
q1 34.93 32.53 -2.399 93.13%
q2 24.94 25.15 0.214 100.86%
q3 38.03 35.63 -2.402 93.68%
q4 37.75 39.47 1.721 104.56%
q5 70.43 69.91 -0.520 99.26%
q6 5.61 7.16 1.559 127.81%
q7 83.75 83.43 -0.328 99.61%
q8 84.91 86.98 2.072 102.44%
q9 122.64 125.57 2.929 102.39%
q10 43.98 42.09 -1.894 95.69%
q11 20.02 20.23 0.206 101.03%
q12 27.23 27.47 0.240 100.88%
q13 45.54 44.85 -0.694 98.48%
q14 18.32 17.86 -0.463 97.47%
q15 28.87 29.77 0.901 103.12%
q16 14.34 13.95 -0.390 97.28%
q17 101.68 100.92 -0.752 99.26%
q18 147.91 146.37 -1.541 98.96%
q19 13.91 13.91 0.003 100.02%
q20 26.33 26.50 0.170 100.64%
q21 223.12 226.25 3.139 101.41%
q22 14.78 13.71 -1.073 92.74%
total 1229.02 1229.72 0.696 100.06%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Track all the failed unit test in Spark 3.4.
3 participants