Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Code clean for ConverterUtils.getFileFormat #4431

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Jan 17, 2024

Remove ConverterUtils.getFileFormat and setDataSchema.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@ulysses-you ulysses-you merged commit 19a863c into apache:main Jan 22, 2024
19 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4431_time.csv log/native_master_01_21_2024_c610efac5_time.csv difference percentage
q1 32.33 34.20 1.872 105.79%
q2 24.06 22.37 -1.687 92.99%
q3 36.50 38.12 1.621 104.44%
q4 38.08 37.47 -0.607 98.41%
q5 68.05 68.25 0.199 100.29%
q6 8.25 7.03 -1.217 85.25%
q7 82.58 81.72 -0.857 98.96%
q8 83.76 85.34 1.580 101.89%
q9 119.52 125.85 6.326 105.29%
q10 42.28 41.56 -0.719 98.30%
q11 19.54 20.02 0.490 102.51%
q12 29.76 28.73 -1.029 96.54%
q13 46.00 45.07 -0.931 97.98%
q14 23.28 18.94 -4.338 81.37%
q15 29.25 28.33 -0.919 96.86%
q16 14.39 14.16 -0.227 98.42%
q17 99.35 98.38 -0.973 99.02%
q18 147.24 146.62 -0.629 99.57%
q19 15.15 12.43 -2.711 82.10%
q20 25.78 25.25 -0.527 97.96%
q21 225.03 223.74 -1.286 99.43%
q22 14.64 13.60 -1.042 92.89%
total 1224.82 1217.21 -7.611 99.38%

@Yohahaha Yohahaha deleted the remove-fileformat-func branch January 22, 2024 10:39
@taiyang-li
Copy link
Contributor

taiyang-li commented Jan 22, 2024

I'm curious about the side effect of removing setDataSchema. Are you sure it it ok for both VL and CH backend? Pls let me know if you are confirm about it @Yohahaha

@ulysses-you
Copy link
Contributor

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_01_22_2024_time.csv log/native_master_01_21_2024_c610efac5_time.csv difference percentage
q1 32.31 34.20 1.898 105.87%
q2 24.07 22.37 -1.704 92.92%
q3 37.08 38.12 1.046 102.82%
q4 38.49 37.47 -1.017 97.36%
q5 68.33 68.25 -0.076 99.89%
q6 7.26 7.03 -0.223 96.93%
q7 83.81 81.72 -2.091 97.51%
q8 83.38 85.34 1.959 102.35%
q9 117.04 125.85 8.806 107.52%
q10 40.47 41.56 1.093 102.70%
q11 20.27 20.02 -0.245 98.79%
q12 27.53 28.73 1.207 104.39%
q13 46.48 45.07 -1.411 96.96%
q14 15.48 18.94 3.465 122.38%
q15 28.47 28.33 -0.141 99.50%
q16 15.34 14.16 -1.175 92.34%
q17 100.56 98.38 -2.187 97.83%
q18 145.52 146.62 1.101 100.76%
q19 12.41 12.43 0.028 100.23%
q20 26.33 25.25 -1.086 95.88%
q21 225.25 223.74 -1.507 99.33%
q22 13.60 13.60 0.003 100.02%
total 1209.47 1217.21 7.742 100.64%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants