-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Code clean for ConverterUtils.getFileFormat #4431
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
237d4ef
to
d22e1b9
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
I'm curious about the side effect of removing setDataSchema. Are you sure it it ok for both VL and CH backend? Pls let me know if you are confirm about it @Yohahaha |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
@ulysses-you I see, thanks for explanation. |
Remove ConverterUtils.getFileFormat and setDataSchema.