[VL] support spark nanvl function #4446
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
cc @rui-mo , thanks |
| @@ -236,6 +236,7 @@ object ExpressionMappings { | |||
| Sig[CheckOverflow](CHECK_OVERFLOW), | |||
| Sig[MakeDecimal](MAKE_DECIMAL), | |||
| Sig[PromotePrecision](PROMOTE_PRECISION), | |||
| Sig[NaNvl](NANVL), | |||
There was a problem hiding this comment.
Do we need this mapping if we replace nanvl with if and isnan?
There was a problem hiding this comment.
This is needed because of check in https://github.com/oap-project/gluten/blob/main/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala#L120.
Thanks.
There was a problem hiding this comment.
Add this func to mappings for velox only now. Thanks.
| @@ -253,6 +253,7 @@ object ExpressionNames { | |||
| final val CHECK_OVERFLOW = "check_overflow" | |||
| final val MAKE_DECIMAL = "make_decimal" | |||
| final val PROMOTE_PRECISION = "promote_precision" | |||
| final val NANVL = "nanvl" | |||
| replaceWithExpressionTransformerInternal(n.right, attributeSeq, expressionsMap), | ||
| replaceWithExpressionTransformerInternal(n.left, attributeSeq, expressionsMap), | ||
| n | ||
| ) |
There was a problem hiding this comment.
Does CH backend need this replacement? cc @zzcclp
There was a problem hiding this comment.
I don't know, but let me to limit this replacement for velox only now, thanks.
|
Run Gluten Clickhouse CI |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)