-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] fix delta column mapping for struct type columns #4530
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
@liujiayi771, @YannByron, @yma11, @JkSelf @zhouyuan could you help review? |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
We only handles column mapping for top layers, if there are struct type columns, then it would cause wrong result (null for struct type columns). This change leverage delta API to map the schema and attributes to solve the above issue.
Repro:
Result:
Wrong plan:
Expected Result:
Expected plan:
How was this patch tested?
UT.