Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix Spark34's shim descriptor to 3.4.2 #4574

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Yohahaha
Copy link
Contributor

No description provided.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit bc4c1ac into apache:main Jan 30, 2024
19 checks passed
@Yohahaha Yohahaha deleted the fix-spark34-shim branch January 30, 2024 06:10
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4574_time.csv log/native_master_01_29_2024_f040fe8d6_time.csv difference percentage
q1 33.65 33.80 0.155 100.46%
q2 23.02 25.67 2.655 111.53%
q3 38.49 38.07 -0.414 98.92%
q4 37.87 40.59 2.710 107.16%
q5 70.67 69.30 -1.375 98.05%
q6 6.72 7.04 0.315 104.69%
q7 81.35 85.84 4.489 105.52%
q8 85.87 86.69 0.818 100.95%
q9 123.52 121.85 -1.669 98.65%
q10 42.61 43.51 0.901 102.11%
q11 19.97 19.98 0.009 100.05%
q12 25.07 29.14 4.065 116.21%
q13 45.58 45.40 -0.178 99.61%
q14 17.29 15.65 -1.636 90.54%
q15 27.30 29.66 2.356 108.63%
q16 14.55 14.28 -0.273 98.12%
q17 100.99 102.13 1.139 101.13%
q18 147.93 149.99 2.061 101.39%
q19 14.98 13.92 -1.059 92.93%
q20 27.02 26.90 -0.122 99.55%
q21 222.71 225.67 2.964 101.33%
q22 13.80 13.48 -0.316 97.71%
total 1220.97 1238.57 17.595 101.44%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants