-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Minor refactor of use ValidationResult for supportWriteFilesExec #4589
[CORE] Minor refactor of use ValidationResult for supportWriteFilesExec #4589
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
@ulysses-you @JkSelf could you help rerun failed CI jobs and review it? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. LGTM except one small comment.
|
||
def validateCompressionCodec(): Option[String] = { | ||
// Velox doesn't support brotli and lzo. | ||
val unSupportedCompressions = Set("brotli, lzo") | ||
val compressionCodec = WriteFilesExecTransformer.getCompressionCodec(options) | ||
if (unSupportedCompressions.contains(compressionCodec)) { | ||
Some("brotli or lzo compression codec is not support in velox backend.") | ||
Some("brotli or lzo compression codec is not support in Velox backend.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brotli
-> Brotli
and support
-> supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
5ec504f
to
d8b7acb
Compare
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
No description provided.