-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3582][CH] Remove Not Support PushDownFilters #4624
Merged
baibaichen
merged 2 commits into
apache:main
from
baibaichen:feature/removeNotSupportPushDownFilters
Feb 4, 2024
Merged
[GLUTEN-3582][CH] Remove Not Support PushDownFilters #4624
baibaichen
merged 2 commits into
apache:main
from
baibaichen:feature/removeNotSupportPushDownFilters
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor WholeStageTransformerSuite for adding GlutenParquetFilterSuite 1. Introduce Arm.withResource to close file for fixing resource leak. 2. Introduce withDataframe for dry run sql. 3. Introduce tpchSQL to simpilfy geting tpch sql from resources
9 tasks
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
zzcclp
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup of #4582, this PR removes unsupported parquet filters for Clickhouse backend. I also refactor
WholeStageTransformerSuite
for addingGlutenParquetFilterSuite
Arm.withResource
to close file for fixing resource leak.withDataframe
for dry run sql.tpchSQL
to simpilfy getting tpch sql from resourcesWhat changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #3582)
How was this patch tested?
Adding new UT.