Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Code refactoring for HashAggregateExecBaseTransformer #4719

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

liujiayi771
Copy link
Contributor

@liujiayi771 liujiayi771 commented Feb 20, 2024

What changes were proposed in this pull request?

As the HashAggregate transformer code has been gradually modified, many of the originally defined interfaces have diversified into implementations across different backends, and many that are only used in subclasses no longer need to be abstracted as interfaces. It is necessary to clean them up.

How was this patch tested?

No logic changing, only moving codes.
Exists CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@liujiayi771
Copy link
Contributor Author

cc @PHILO-HE @ulysses-you, thanks.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@ulysses-you ulysses-you merged commit c3614f8 into apache:main Feb 20, 2024
21 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4719_time.csv log/native_master_02_19_2024_72960de81_time.csv difference percentage
q1 31.87 33.43 1.569 104.92%
q2 26.43 24.73 -1.702 93.56%
q3 35.96 37.94 1.977 105.50%
q4 38.88 37.71 -1.176 96.98%
q5 69.57 70.80 1.230 101.77%
q6 5.45 7.31 1.853 133.99%
q7 86.26 82.80 -3.453 96.00%
q8 85.87 86.79 0.928 101.08%
q9 123.80 121.45 -2.351 98.10%
q10 44.17 41.30 -2.875 93.49%
q11 20.33 20.02 -0.306 98.49%
q12 27.69 26.06 -1.635 94.10%
q13 45.17 45.68 0.508 101.13%
q14 16.64 15.10 -1.544 90.72%
q15 30.57 27.77 -2.802 90.83%
q16 12.72 14.10 1.375 110.81%
q17 102.73 102.85 0.124 100.12%
q18 148.36 149.16 0.800 100.54%
q19 14.14 13.92 -0.217 98.47%
q20 26.98 26.87 -0.111 99.59%
q21 224.89 226.51 1.619 100.72%
q22 15.15 13.67 -1.480 90.23%
total 1233.63 1225.96 -7.668 99.38%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_20_2024_time.csv log/native_master_02_19_2024_72960de81_time.csv difference percentage
q1 34.24 33.43 -0.811 97.63%
q2 24.42 24.73 0.309 101.26%
q3 38.78 37.94 -0.838 97.84%
q4 38.03 37.71 -0.325 99.15%
q5 70.83 70.80 -0.027 99.96%
q6 7.23 7.31 0.072 100.99%
q7 82.68 82.80 0.124 100.15%
q8 85.38 86.79 1.413 101.65%
q9 126.15 121.45 -4.706 96.27%
q10 43.25 41.30 -1.955 95.48%
q11 20.79 20.02 -0.766 96.32%
q12 26.48 26.06 -0.416 98.43%
q13 44.88 45.68 0.800 101.78%
q14 18.88 15.10 -3.784 79.96%
q15 29.18 27.77 -1.409 95.17%
q16 15.42 14.10 -1.322 91.43%
q17 102.55 102.85 0.297 100.29%
q18 149.13 149.16 0.030 100.02%
q19 12.57 13.92 1.347 110.71%
q20 26.34 26.87 0.529 102.01%
q21 225.83 226.51 0.683 100.30%
q22 13.68 13.67 -0.007 99.95%
total 1236.72 1225.96 -10.761 99.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants