Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4039] [VL] Add ntile window function support in Gluten #4776

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Feb 26, 2024

What changes were proposed in this pull request?

Add ntile window function support in velox backend.

How was this patch tested?

adding new unit tests

Copy link

#4039

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@Surbhi-Vijay Surbhi-Vijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your change! Can you please update the documentation as well?

Copy link

Run Gluten Clickhouse CI

@JkSelf
Copy link
Contributor Author

JkSelf commented Feb 27, 2024

Thank you for your change! Can you please update the documentation as well?
@Surbhi-Vijay Thanks for your remind. Updated the document.

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit 420ffd1 into apache:main Feb 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants