Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove lead/lag ignoreNulls workaround #5084

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Velox has fixed this issue, so it would be better to remove the workaround.

How was this patch tested?

Pass CI

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

cc @PHILO-HE thank you

@PHILO-HE
Copy link
Contributor

Run Gluten Clickhouse CI

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit dafb371 into apache:main Mar 22, 2024
17 of 20 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5084_time.csv log/native_master_03_21_2024_9d859d8e4_time.csv difference percentage
q1 37.55 36.78 -0.772 97.94%
q2 24.23 23.82 -0.413 98.30%
q3 38.37 36.97 -1.394 96.37%
q4 38.27 38.29 0.021 100.05%
q5 70.56 68.82 -1.733 97.54%
q6 7.02 7.79 0.771 110.98%
q7 83.52 82.16 -1.361 98.37%
q8 85.62 85.93 0.309 100.36%
q9 124.37 120.31 -4.068 96.73%
q10 44.19 43.15 -1.032 97.66%
q11 20.35 20.44 0.096 100.47%
q12 29.23 26.75 -2.488 91.49%
q13 47.44 48.78 1.336 102.82%
q14 18.13 21.16 3.031 116.72%
q15 30.83 28.73 -2.097 93.20%
q16 13.89 14.42 0.529 103.81%
q17 100.55 99.19 -1.361 98.65%
q18 142.52 139.46 -3.056 97.86%
q19 15.11 15.07 -0.040 99.74%
q20 26.46 27.86 1.400 105.29%
q21 224.80 226.99 2.186 100.97%
q22 13.86 14.13 0.267 101.92%
total 1236.86 1226.99 -9.869 99.20%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_03_22_2024_time.csv log/native_master_03_21_2024_9d859d8e4_time.csv difference percentage
q1 36.00 36.78 0.781 102.17%
q2 23.88 23.82 -0.061 99.74%
q3 39.77 36.97 -2.796 92.97%
q4 37.04 38.29 1.244 103.36%
q5 68.89 68.82 -0.070 99.90%
q6 7.37 7.79 0.423 105.73%
q7 81.87 82.16 0.296 100.36%
q8 84.88 85.93 1.050 101.24%
q9 121.41 120.31 -1.108 99.09%
q10 45.37 43.15 -2.217 95.11%
q11 19.66 20.44 0.781 103.97%
q12 26.63 26.75 0.117 100.44%
q13 47.86 48.78 0.920 101.92%
q14 19.67 21.16 1.494 107.59%
q15 30.13 28.73 -1.400 95.35%
q16 15.49 14.42 -1.077 93.05%
q17 101.32 99.19 -2.138 97.89%
q18 143.26 139.46 -3.801 97.35%
q19 13.86 15.07 1.210 108.73%
q20 28.63 27.86 -0.774 97.30%
q21 230.55 226.99 -3.568 98.45%
q22 13.91 14.13 0.223 101.60%
total 1237.47 1226.99 -10.473 99.15%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_03_23_2024_time.csv log/native_master_03_22_2024_dafb3715e_time.csv difference percentage
q1 35.94 36.00 0.056 100.16%
q2 26.49 23.88 -2.613 90.14%
q3 36.42 39.77 3.353 109.21%
q4 39.82 37.04 -2.775 93.03%
q5 70.31 68.89 -1.416 97.99%
q6 7.44 7.37 -0.068 99.09%
q7 84.22 81.87 -2.352 97.21%
q8 82.64 84.88 2.239 102.71%
q9 119.12 121.41 2.298 101.93%
q10 44.06 45.37 1.311 102.98%
q11 20.12 19.66 -0.460 97.71%
q12 25.18 26.63 1.446 105.74%
q13 49.15 47.86 -1.296 97.36%
q14 19.49 19.67 0.177 100.91%
q15 31.13 30.13 -1.002 96.78%
q16 14.10 15.49 1.396 109.90%
q17 99.73 101.32 1.590 101.59%
q18 140.89 143.26 2.376 101.69%
q19 14.90 13.86 -1.038 93.03%
q20 26.93 28.63 1.699 106.31%
q21 228.87 230.55 1.682 100.74%
q22 14.00 13.91 -0.091 99.35%
total 1230.96 1237.47 6.512 100.53%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_03_24_2024_time.csv log/native_master_03_23_2024_dafb3715e_time.csv difference percentage
q1 36.08 35.94 -0.137 99.62%
q2 25.46 26.49 1.027 104.03%
q3 35.09 36.42 1.325 103.78%
q4 39.91 39.82 -0.096 99.76%
q5 67.67 70.31 2.641 103.90%
q6 7.60 7.44 -0.164 97.84%
q7 84.78 84.22 -0.561 99.34%
q8 89.13 82.64 -6.494 92.71%
q9 120.73 119.12 -1.615 98.66%
q10 45.20 44.06 -1.142 97.47%
q11 20.04 20.12 0.084 100.42%
q12 24.61 25.18 0.574 102.33%
q13 47.96 49.15 1.197 102.50%
q14 20.07 19.49 -0.583 97.10%
q15 32.70 31.13 -1.572 95.19%
q16 14.79 14.10 -0.689 95.34%
q17 100.40 99.73 -0.669 99.33%
q18 141.27 140.89 -0.379 99.73%
q19 13.76 14.90 1.134 108.24%
q20 27.91 26.93 -0.977 96.50%
q21 223.33 228.87 5.547 102.48%
q22 14.13 14.00 -0.128 99.10%
total 1232.63 1230.96 -1.676 99.86%

@ulysses-you ulysses-you deleted the offset branch March 25, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants