[GLUTEN-5192][VL] Copy bundle jars to dist dir #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
previously approved these changes
Apr 1, 2024
ulysses-you
reviewed
Apr 1, 2024
| @@ -4,17 +4,28 @@ set -eux | |||
|
|
|||
| CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) | |||
| GLUTEN_DIR="$CURRENT_DIR/.." | |||
| THIRDPARTY_LIB="$GLUTEN_DIR/package/target/thirdparty-lib" | |||
| DISTDIR="$GLUTEN_DIR/dist" | |||
| THIRDPARTY_LIB="$DISTDIR/thirdparty-lib" | |||
There was a problem hiding this comment.
I guess there are some docs should be updated
There was a problem hiding this comment.
Thanks, there seems to be no more documentation, just a commented script..
ulysses-you
reviewed
Apr 1, 2024
| mvn clean package -Pbackends-velox -Prss -Pspark-3.2 -DskipTests | ||
| cp package/target/gluten-*-bundle-spark*.jar "$DISTDIR" |
There was a problem hiding this comment.
should we use mv ? It will make binary size bigger
There was a problem hiding this comment.
should we use
mv? It will make binary size bigger
The package/target directory is just the mvn build output directory of package module, I think we don't need to care about its size, it will be cleaned after mvn clean.
4 tasks
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
closes #5192
How was this patch tested?
run
./dev/package.shafter this change: