[GLUTEN-4039][VL] Implement stack function #5813
Conversation
|
@marin-ma Can you help review? |
|
Run Gluten Clickhouse CI |
|
LGTM. Thanks. Could you rebase and run |
xumingming
force-pushed
the
implement-stack
branch
from
e3e786a
to
6bb9d52
Compare
|
Run Gluten Clickhouse CI |
We insert a ProjectExec before GenerateExec to organize stack's params as several arrays, these arrays then would be unnested using Unnest operator, for query: select stack(2, id, name, id1, name1) The plan is: Generate stack(2, id#122, name#123, id1#124, name1#125), false, [col0#137, col1#138] +- Project [id#122, name#123, id1#124, name1#125, array(id#122, id1#124) AS _pre_0#141, array(name#123,name1#125) AS _pre_1#142] +- RewrittenNodeWall LocalTableScan [id#122, name#123, id1#124, name1#125]
xumingming
force-pushed
the
implement-stack
branch
from
6bb9d52
to
2e87836
Compare
|
Run Gluten Clickhouse CI |
@marin-ma Rebased, and the test passed. Just curious, do we always need to keep our PR branch update to date with gluten's main branch? After the test passed, the main branch updated again and the PR says "This branch is out-of-date with the base branch" again. |
|
@xumingming We don't. But if there are any conflict with main branch, the merging will be blocked. |
We insert a ProjectExec before GenerateExec to organize stack's params as several arrays, these arrays then would be unnested using Unnest operator, for query:
select stack(2, id, name, id1, name1)
The plan is:
Generate stack(2, id#122, name#123, id1#124, name1#125), false, [col0#137, col1#138] +- Project [id#122, name#123, id1#124, name1#125, array(id#122, id1#124) AS _pre_0#141, array(name#123,name1#125) AS _pre_1#142]
+- RewrittenNodeWall LocalTableScan [id#122, name#123, id1#124, name1#125]