Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-286] fix bug where non hive dataset publishing gives NPE #2148

Closed

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Oct 24, 2017

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @htran1 please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Currently non hive dataset do not have datasetOutputPath populated in copyableFile, ths throwing NPE while trying to access it. This PR will fix this bug where non hive dataset throw NPE during publish.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    It is not a new feature, just a minor fix. So not adding any test case.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@asfgit asfgit closed this in 056888e Oct 24, 2017
zxliucmu pushed a commit to zxliucmu/incubator-gobblin that referenced this pull request Nov 16, 2017
@arjun4084346 arjun4084346 deleted the fixBugNonHiveDataset branch June 2, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants