Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfoVersion to store version information of info and support data type extension base on info version #27

Merged
merged 11 commits into from Dec 13, 2022

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Dec 12, 2022

Proposed changes

These changes are intend to support the feature that GraphAr Info can extend their supported data types base on their info version. Here we implement the feature by:

  • Add a class InfoVersion to store the version information of info and provide function to parse version string.
  • Modify the Info classes (VertexInfo, EdgeInfo, GraphInfo) constructor to support version attribute.
  • Revise the DataType helper functions to adapt the version info.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #2

Fix

Fix

Fix

Fix

Fix

Fix

Fix

Fix

Fix

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Fix

Fix

Fix

Update

update
@acezen acezen marked this pull request as ready for review December 12, 2022 07:58
@acezen
Copy link
Contributor Author

acezen commented Dec 12, 2022

\cc @lixueclaire The pull request is ready for review~

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I have no more comments.

@acezen acezen merged commit 18e3f61 into apache:main Dec 13, 2022
@acezen acezen deleted the 2-extending-version-attribute branch December 13, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Support data type extension in graph information base on version attribute of Infos
2 participants