Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][C++] Change the default namespace to graphar #413

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 25, 2024

Proposed changes

as #412 describe

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close issue #412

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Copy link
Contributor Author

acezen commented Mar 25, 2024

The upstream arrow's debain package seems break apache/arrow#40759

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lixueclaire lixueclaire merged commit f77897e into apache:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants