Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra][Java] Repackaging Java library under the Apache namespace #429

Merged
merged 5 commits into from
Mar 28, 2024
Merged

[Infra][Java] Repackaging Java library under the Apache namespace #429

merged 5 commits into from
Mar 28, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 28, 2024 •
edited
Loading

Proposed changes

  • packaging from com.alibaba to org.apache
  • update the code directory structure from com/alibaba/graphar to org/apache/graphar
  • update related document

related to issue #427

@acezen
Copy link
Contributor Author

acezen commented Mar 28, 2024

@lixueclaire @Thespica This pull request may needs your review.

@acezen
[Infra][Java] Repackaging Java library under the Apache namespace
184b48b 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Rename the directories
3398598 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Fix format
51e134e 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Fix error
46a173f 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@Thespica
Copy link
Contributor

Thespica commented Mar 28, 2024 •
edited
Loading

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

@acezen
Fix
1999158 
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen
Copy link
Contributor Author

acezen commented Mar 28, 2024

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

Fixed, thanks for the review

@acezen
Copy link
Contributor Author

acezen commented Mar 28, 2024

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

The CI is passed. Please review again, thanks~

Thespica
Thespica approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 49c0bdc into apache:main Mar 28, 2024
3 checks passed
@acezen acezen deleted the repackaging-java branch March 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thespica Thespica Thespica approved these changes

@lixueclaire lixueclaire Awaiting requested review from lixueclaire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acezen @Thespica