Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the spark tool of GraphAr and implement the Info and IndexGenerator #45

Merged
merged 13 commits into from Dec 16, 2022

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Dec 14, 2022

Proposed changes

These changes initialize the code base of GraphAr spark tool and implement the Info classes for spark tool.

  • initialize the code base of spark tool
  • add GraphInfo, EdgeInfo and VertexInfo
  • add related unit tests for info classes
  • integrate to CI

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed issue #32

@acezen acezen marked this pull request as ready for review December 15, 2022 02:25
@acezen acezen changed the title Initialize the spark tool of GraphAr Initialize the spark tool of GraphAr and implement the Info and IndexGenerator Dec 16, 2022
@acezen
Copy link
Contributor Author

acezen commented Dec 16, 2022

@lixueclaire any review comments?

@lixueclaire
Copy link
Contributor

I think "GetDirPath" (for VertexInfo) and "GetAdjListDirPath"/"GetAdjListOffsetDirPath"/"GetPropertyDirPath" (for EdgeInfo) could be added for aligning with C++ SDK

@acezen
Copy link
Contributor Author

acezen commented Dec 16, 2022

I think "GetDirPath" (for VertexInfo) and "GetAdjListDirPath"/"GetAdjListOffsetDirPath"/"GetPropertyDirPath" (for EdgeInfo) could be added for aligning with C++ SDK

The Dir-related methods have been updated.

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ready for merging~

return false
}

def containProperty(property_name: String): Boolean = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if "adj_list_type" is necessary as a input parameter for this function, also consider the functions:
def getPropertyType(property_name: String): GarType.Value
def isPrimaryKey(property_name: String): Boolean
def getPrimaryKey(): String

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emm, you are right. adj_list_type should be include in these functions and the c++ Info class also need to updated.
This pull request can aligned to c++ at first and I will open an issue for these change and solved it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants